Skip to content

HDDS-8383. Misreplication cannot be resolved with single rack #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 12 commits into from
Apr 11, 2023
Merged

HDDS-8383. Misreplication cannot be resolved with single rack #4539

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8e6b956
HDDS-8383. Misreplication cannot be resolved with single rack
adoroszlai Apr 5, 2023
251eeb7
Use new getRackCount method to reduce duplication
adoroszlai Apr 5, 2023
1ef8ae9
Fix at root SCMContainerPlacementRackAware#getRequiredRackCount inste…
adoroszlai Apr 10, 2023
3e3adb2
Fix TestContainerPlacementStatusDefault
adoroszlai Apr 10, 2023
7a0b56a
Apply same fix in PipelinePlacementPolicy
adoroszlai Apr 10, 2023
2d59517
Revert "Apply same fix in PipelinePlacementPolicy"
adoroszlai Apr 11, 2023
7e871b3
Revert "Fix TestContainerPlacementStatusDefault"
adoroszlai Apr 11, 2023
bfd3791
Revert "Fix at root SCMContainerPlacementRackAware#getRequiredRackCou…
adoroszlai Apr 11, 2023
a261e76
Revert "Use new getRackCount method to reduce duplication"
adoroszlai Apr 11, 2023
8731b61
Revert "HDDS-8383. Misreplication cannot be resolved with single rack"
adoroszlai Apr 11, 2023
8ca9e43
HDDS-8383. Misreplication cannot be resolved with single rack
adoroszlai Apr 11, 2023
3e1a0e7
Merge remote-tracking branch 'origin/master' into HDDS-8383
adoroszlai Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@ protected int getMaxReplicasPerRack(int numReplicas, int numberOfRacks) {

@Override
protected int getRequiredRackCount(int numReplicas) {
return REQUIRED_RACKS;
int racks = networkTopology != null
? networkTopology.getNumOfNodes(networkTopology.getMaxLevel() - 1)
: 1;
return Math.min(REQUIRED_RACKS, racks);
Copy link
Contributor

@swamirishi swamirishi Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, this is the only change which fixes the particular issue. I think it would be better to create another refactoring jira, if you want to change the other interfaces.

}
}