Skip to content

HDDS-8364. ReadReplicas may give wrong results with topology-aware read enabled #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 1 commit into from
Apr 4, 2023
Merged

HDDS-8364. ReadReplicas may give wrong results with topology-aware read enabled #4522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Optional;
Expand Down Expand Up @@ -541,6 +542,12 @@ public Builder setLeaderId(UUID leaderId1) {
public Builder setNodes(List<DatanodeDetails> nodes) {
this.nodeStatus = new LinkedHashMap<>();
nodes.forEach(node -> nodeStatus.put(node, -1L));
if (nodesInOrder != null) {
// nodesInOrder may belong to another pipeline, avoid overwriting it
nodesInOrder = new LinkedList<>(nodesInOrder);
// drop nodes no longer part of the pipeline
nodesInOrder.retainAll(nodes);
}
return this;
}

Expand Down
4 changes: 0 additions & 4 deletions ...ne/client/src/main/java/org/apache/hadoop/ozone/client/checksum/ECFileChecksumHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,16 +173,12 @@ private List<ContainerProtos.ChunkInfo> getChunkInfos(OmKeyLocationInfo
nodes.add(dn);
}
}
List<DatanodeDetails> nodesInOrder =
new ArrayList<>(pipeline.getNodesInOrder());
nodesInOrder.retainAll(nodes);

pipeline = Pipeline.newBuilder(pipeline)
.setReplicationConfig(StandaloneReplicationConfig
.getInstance(HddsProtos.ReplicationFactor.THREE))
.setNodes(nodes)
.build();
pipeline.setNodesInOrder(nodesInOrder);

List<ContainerProtos.ChunkInfo> chunks;
XceiverClientSpi xceiverClientSpi = null;
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/smoketest/debug/ozone-debug.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Resource ../lib/os.robot

*** Keywords ***
Execute read-replicas CLI tool
Execute ozone debug read-replicas o3://om/${VOLUME}/${BUCKET}/${TESTFILE}
Execute ozone debug -Dozone.network.topology.aware.read=true read-replicas o3://om/${VOLUME}/${BUCKET}/${TESTFILE}
${directory} = Execute ls -d /opt/hadoop/${VOLUME}_${BUCKET}_${TESTFILE}_*/ | tail -n 1
Directory Should Exist ${directory}
File Should Exist ${directory}/${TESTFILE}_manifest
Expand Down