HDDS-8361. Useless object in TestOzoneBlockTokenIdentifier #4517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @hemantk-12 can you please take a look? |
ChenSammi
reviewed
Apr 4, 2023
| } | ||
|
|
||
| public void testSymmetricTokenPerfHelper(String hmacAlgorithm, int keyLen) { | ||
| private void testSymmetricTokenPerfHelper(String hmacAlgorithm, int keyLen) { |
Contributor
There was a problem hiding this comment.
@adoroszlai , thanks for fix the issue.
Does the scope change from public to private solve the problem?
Contributor
Author
There was a problem hiding this comment.
No, the problem is fixed by actually using the "useless object" here:
LOG.info("Average token sign time with {}({} symmetric key) is {} ns",
hmacAlgorithm, keyLen, duration / tokenPasswordSym.size());
ChenSammi
reviewed
Apr 4, 2023
| <dependency> | ||
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
OzoneBlockTokenIdentifier is in hadoop-hdds/common, so I'm moving the test to the same submodule. This dependency is required at runtime for Hadoop code invoked by the test.
[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.506 s <<< FAILURE! - in org.apache.hadoop.hdds.security.token.TestOzoneBlockTokenIdentifier
[ERROR] org.apache.hadoop.hdds.security.token.TestOzoneBlockTokenIdentifier.testTokenSerialization Time elapsed: 0.04 s <<< ERROR!
java.lang.NoClassDefFoundError: org/apache/commons/codec/binary/Base64
at org.apache.hadoop.security.token.Token.encodeWritable(Token.java:342)
at org.apache.hadoop.security.token.Token.encodeToUrlString(Token.java:373)
at org.apache.hadoop.hdds.security.token.TestOzoneBlockTokenIdentifier.testTokenSerialization(TestOzoneBlockTokenIdentifier.java:169)
Contributor
|
The patch LGTM +1. |
Contributor
Author
|
Thanks @ChenSammi for reviewing and committing it. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Apr 6, 2023
* master: (155 commits) update readme (apache#4535) HDDS-8374. Disable flaky unit test: TestContainerStateCounts HDDS-8016. updated the ozone doc for linked bucket and deletion async limitation (apache#4526) HDDS-8237. [Snapshot] loadDb() used by SstFiltering service creates extraneous directories. (apache#4446) HDDS-8035. Intermittent timeout in TestOzoneManagerHAWithData.testOMHAMetrics (apache#4362) HDDS-8039. Allow container inspector to run from ozone debug. (apache#4337) HDDS-8304. [Snapshot] Reduce flakiness in testSkipTrackingWithZeroSnapshot (apache#4487) HDDS-7974. [Snapshot] KeyDeletingService to be aware of Ozone snapshots (apache#4486) HDDS-8368. ReplicationManager: Create ContainerReplicaOp with correct target Datanode (apache#4532) HDDS-8358. Fix the space usage comparator in ContainerBalancerSelectionCriteria (apache#4527) HDDS-8359. ReplicationManager: Fix getContainerReplicationHealth() so that it builds ContainerCheckRequest correctly (apache#4528) HDDS-8361. Useless object in TestOzoneBlockTokenIdentifier (apache#4517) HDDS-8325. Consolidate and refine RocksDB metrics of services (apache#4506) HDDS-8135. Incorrect synchronization during certificate renewal in DefaultCertificateClient. (apache#4381) HDDS-8127. Exclude deleted containers from Recon container count (apache#4440) HDDS-8364. ReadReplicas may give wrong results with topology-aware read enabled (apache#4522) HDDS-8354. Avoid WARNING about ObjectEndpoint#get (apache#4515) HDDS-8324. DN data cache gets removed randomly asking for data from disk (apache#4499) HDDS-8291. Upgrade to Hadoop 3.3.5 (apache#4484) HDDS-8355. Mark TestOMRatisSnapshots#testInstallSnapshot as flaky ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix findbugs violation in
TestOzoneBlockTokenIdentifier, which interestingly only appeared in #4506 without any change in that file.Few other minor fixes in the same file.
https://issues.apache.org/jira/browse/HDDS-8361
How was this patch tested?
Findbugs and unit test.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4594024215