HDDS-8300. Enable topology aware replication and reads by default. #4489
Conversation
|
Topology-aware read breaks EC file checksums (HDDS-8276). I have converted this to draft, because we need to fix that first. |
|
@ashishkumar50 After fixing HDDS-8276, the following problems are left:
Can you please check? |
|
@adoroszlai , TestXceiverClientGrpc test issue is fixed, we need to disable topology read for shuffle read from DN which is used in testRandomFirstNodeIsCommandTarget case. |
Filed HDDS-8364 for the bug in |
| @Test | ||
| public void testDefaultPolicy() throws IOException { | ||
| public void testRackAwareContainerPolicy() throws IOException { | ||
| conf.set(ScmConfigKeys.OZONE_SCM_CONTAINER_PLACEMENT_IMPL_KEY, | ||
| SCMContainerPlacementRackAware.class.getName()); | ||
| PlacementPolicy policy = ContainerPlacementPolicyFactory | ||
| .getPolicy(conf, null, null, true, null); | ||
| Assertions.assertSame(SCMContainerPlacementRandom.class, policy.getClass()); | ||
| Assertions.assertSame(SCMContainerPlacementRackAware.class, | ||
| policy.getClass()); | ||
| } |
There was a problem hiding this comment.
I would have preferred keeping the intention of this test: testing default setting. Sorry for not noticing this earlier.
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Sorry @ashishkumar50 for the late notice, but after checking results of TestDecommissionAndMaintenance, it seems testContainerIsReplicatedWhenAllNodesGotoMaintenance is consistently failing (timing out).
3 participants
What changes were proposed in this pull request?
Enable topology aware replication and read by default.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8300
How was this patch tested?
Test using TestSCMContainerPlacementRackAware integration test.