Skip to content

HDDS-8154. Perf: Reuse Mac instances in S3 token validation #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kerneltime merged 2 commits into from
Mar 22, 2023
Merged

HDDS-8154. Perf: Reuse Mac instances in S3 token validation #4433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c5e4a
HDDS-8154. Perf: Reuse Mac instances in S3 token validation
tanvipenumudy Mar 20, 2023
4a1c043
Update hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozo…
tanvipenumudy Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...zone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/AWSV4AuthValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,20 @@ final class AWSV4AuthValidator {
private AWSV4AuthValidator() {
}

/**
* ThreadLocal cache of Mac instances.
*/
private static final ThreadLocal<Mac> THREAD_LOCAL_MAC =
ThreadLocal.withInitial(() -> {
try {
return Mac.getInstance(HMAC_SHA256_ALGORITHM);
} catch (NoSuchAlgorithmException nsa) {
throw new IllegalArgumentException(
"Failed to initialize Mac instance that implements the " +
HMAC_SHA256_ALGORITHM + " algorithm.", nsa);
}
});

public static String hash(String payload) throws NoSuchAlgorithmException {
MessageDigest md = MessageDigest.getInstance("SHA-256");
md.update(payload.getBytes(StandardCharsets.UTF_8));
Expand All @@ -52,7 +66,9 @@ public static String hash(String payload) throws NoSuchAlgorithmException {
private static byte[] sign(byte[] key, String msg) {
try {
SecretKeySpec signingKey = new SecretKeySpec(key, HMAC_SHA256_ALGORITHM);
Mac mac = Mac.getInstance(HMAC_SHA256_ALGORITHM);
// Returns the cached Mac instance for the current thread or creates a
// new one if none exists.
Mac mac = THREAD_LOCAL_MAC.get();
mac.init(signingKey);
return mac.doFinal(msg.getBytes(StandardCharsets.UTF_8));
} catch (GeneralSecurityException gse) {
Expand Down