HDDS-8122. [Snapshot] Disable RocksDB column family auto compaction in SstFilteringService #4400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as well as garbage collection tasks
swamirishi
changed the title
swamirishi
changed the title
# Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java
smengcl
approved these changes
Mar 16, 2023
Contributor
Author
In the case of DB Profile TEST we are disabling auto compaction, by default. We don't want it get overriden. |
Contributor
Ok. Makes sense. Thanks Swami! |
smengcl
changed the title
Contributor
|
@swamirishi We are not quite disabling CF auto compaction in GC or SnapDiff yet IIUC. Thus the title change. It can be added in #4407 or a new PR. cc @aswinshakil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need to make sure that Snapshot RocksDB instance are opened with configuration option that turns of the auto-compaction.
We open rocksDB for snapshot in RW for file filtering service. This is to delete some irrelevant SST files from the snapshot rocksDB manifest. We need to make sure that one of the configuration option in rocksDB option turns of Auto compaction.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8102
https://issues.apache.org/jira/browse/HDDS-8122
How was this patch tested?
Unit Tests & Integration Tests