Skip to content

HDDS-8151. Support fine grained lifetime for root CA certificate #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenSammi merged 4 commits into from
Mar 14, 2023
Merged

HDDS-8151. Support fine grained lifetime for root CA certificate #4386

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e2fd37
HDDS-8151. Support fine grained lifetime for root CA certificate
ChenSammi Mar 13, 2023
5dcd23a
remove unused imports
ChenSammi Mar 13, 2023
f55dfbe
solve findbugs issue
ChenSammi Mar 13, 2023
d91c1c6
remove unnecessary tests
ChenSammi Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/DefaultCAServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@
import java.security.cert.CertificateException;
import java.security.cert.X509Certificate;
import java.security.spec.InvalidKeySpecException;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.time.ZoneId;
import java.util.Date;
import java.util.List;
Expand Down Expand Up @@ -566,8 +564,7 @@ private void generateRootCertificate(
SecurityConfig securityConfig, KeyPair key)
throws IOException, SCMSecurityException {
Preconditions.checkNotNull(this.config);
LocalDateTime beginDate =
LocalDateTime.of(LocalDate.now(), LocalTime.MIDNIGHT);
LocalDateTime beginDate = LocalDateTime.now();
LocalDateTime endDate =
beginDate.plus(securityConfig.getMaxCertificateDuration());
SelfSignedCertificate.Builder builder = SelfSignedCertificate.newBuilder()
Expand Down