HDDS-8025. ReplicationManager: Count a container once for missing, under, mis or over replicated #4313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der, mis or over replicated
adoroszlai
approved these changes
Feb 24, 2023
Contributor
|
@sodonnel some test failure in re-run looks related: |
Contributor
Author
Yea I missed those ones. Easy to fix so I have pushed a new commit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a container is missing, then the new Replication Manager currently counts 1 in the report for under replicated and 1 for missing, meaning the container is double counted.
It makes more sense if we only count under-replicated OR missing. Technically a missing container is also under-replicated, but it makes the report confusing when the container is in two states.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8025
How was this patch tested?
Modified some existing tests.