HDDS-7861. [Snapshot] Delete keys from the source bucket to fix the flakiness of snapshot restore tests #4230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshot restore tests.
Contributor
|
+1 LGTM. |
slfan1989
approved these changes
Feb 1, 2023
hemantk-12
changed the title
hemantk-12
changed the title
hemantk-12
changed the title
...gration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneSnapshotRestore.java
Show resolved
Hide resolved
smengcl
approved these changes
Feb 1, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Huge thanks to @hemantk-12 for digging into this.
Thanks @slfan1989 and @prashantpogde for the reviews.
smengcl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Snapshot restore integration test fails when restoring form bucket1's snapshot to bucket2 for legacy bucket type.
This change is to delete keys from the source bucket. This is temporary fix to make sure that test passes all the time.
If we don't delete keys from the source bucket, copy command will fail. In copy command, there is a check to make sure that key doesn't exist in the destination bucket.
Problem is that RocksDB's seek operation doesn't 100% guarantee that item key is available. Tho we believe that it is. When we seek if there is a directory for the key name, sometime it returns non-null response but in reality item doesn't exist.
Here, sometimes seek returns null and sometimes it return source bucket (which is wrong). When is returns source bucket, we create fake dir and return the non-null response.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7861
How was this patch tested?
Existing integration tests.