Skip to content

Update pull_request_template.md #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
avijayanhwx wants to merge 1 commit into from
Closed

Update pull_request_template.md #42

avijayanhwx wants to merge 1 commit into from

Conversation

@avijayanhwx
Copy link
Contributor

@avijayanhwx avijayanhwx commented Oct 16, 2019

Update Pull Request Template

@anuengineer
Copy link
Contributor

anuengineer commented Oct 16, 2019

We need a JIRA number to commit anything into the branch. So you will have to file a JIRA and refer to that in the pull request. and it might be a good idea to add needing a link to the original JIRA also.

@adoroszlai
Copy link
Contributor

adoroszlai commented Oct 16, 2019 •
edited
Loading

This was is already being done in #5.

@vivekratnavel
Copy link
Contributor

vivekratnavel commented Oct 16, 2019

Yes, #5 is not merged yet. We can close this PR and merge #5.

@avijayanhwx
Copy link
Contributor Author

avijayanhwx commented Oct 16, 2019

Thanks @adoroszlai. I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vivekratnavel vivekratnavel vivekratnavel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avijayanhwx @anuengineer @adoroszlai @vivekratnavel