HDDS-7798. [Snapshot] Add SnapDiff test cases; add config to allow disabling native libs for SnapDiff #4187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamirishi
changed the title
swamirishi
changed the title
swamirishi
changed the title
Contributor
|
@swamirishi Can you please rebase this PR to master ? We will be merging changes in to master going forward. |
Contributor
|
@DaveTeng0 Can you please review this ? |
Contributor
|
Need a rebase (merge) and CI fixes. |
# Conflicts: # hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java
Contributor
|
Blocked by #4678 |
# Conflicts: # .github/workflows/ci.yml # hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java # hadoop-ozone/dev-support/checks/junit.sh # hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java # hadoop-ozone/ozone-manager/pom.xml # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/SnapshotTestUtils.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java # pom.xml
smengcl
reviewed
Jun 30, 2023
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
...op-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/SnapshotDiffHandler.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 30, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Jun 30, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @swamirishi for the great test additions. We can have a follow-up jira to refactor (deduplicate) the test.
Pending nit addressal and green CI.
smengcl
changed the title
Contributor
|
Thanks @swamirishi for the test additions and fixes. Thanks @hemantk-12 for reviewing this. |
Contributor
I don't see such a follow-up task. Also, please note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding testcases to test functionality of snapdiff & key reclaimation in snapshots.
Adding a flag to force snapdiff without using the native libraries. This is to give the users an option to debug any correctness issue in snapdiff to understand diff b/w the 2 diff flows.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7798
How was this patch tested?
Unit Tests