HDDS-7792. Fix package name typos in o.a.h.hdds.security.x509 #4184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
approved these changes
Jan 18, 2023
adoroszlai
changed the title
Contributor
Author
|
rebased after #4179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The certificate.utils package name is clearly a typo, all the contents are in the certificate.xxxx packages, so move classes to the certificate.utils package (which has only a package-info.java), and remove the certificates package.
The exceptions package does not look right with plural, it contains one certificate, and most of our package name is not in plural.
authority.PKIProfiles as a package name is not conforming with the java conventions, package names should be lowercase, therefore renamed it to just profile, for someone who looks into SSL certificates, a certificate profile is a known thing, I don't think we need to keep PKI in the name.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7792
How was this patch tested?
No tests were done or added, logic was not changed, and all the code changes are in imports, package name values, and fully qualified classnames.