Skip to content

HDDS-7787. GetChecksum for EC files can fail intermittently with IndexOutOfBounds exception #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sodonnel merged 1 commit into from
Jan 17, 2023
Merged

HDDS-7787. GetChecksum for EC files can fail intermittently with IndexOutOfBounds exception #4180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions ...ne/client/src/main/java/org/apache/hadoop/ozone/client/checksum/ECFileChecksumHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,25 +161,22 @@ private List<ContainerProtos.ChunkInfo> getChunkInfos(OmKeyLocationInfo

Pipeline pipeline = keyLocationInfo.getPipeline();

List<DatanodeDetails> nodes = pipeline.getNodes();
List<DatanodeDetails> newNodes = new ArrayList<>();
List<DatanodeDetails> nodes = new ArrayList<>();
ECReplicationConfig repConfig = (ECReplicationConfig)
pipeline.getReplicationConfig();
int totalNodes = repConfig.getRequiredNodes();
int parity = repConfig.getParity();

// Filtering the nodes that has the checksumBytes
for (int i = 0; i < nodes.size(); i++) {
if (i > 0 && i < totalNodes - parity) {
continue;
for (DatanodeDetails dn : pipeline.getNodes()) {
int replicaIndex = pipeline.getReplicaIndex(dn);
if (replicaIndex == 1 || replicaIndex > repConfig.getData()) {
// The stripe checksum we need to calculate checksums is only stored on
// replica_index = 1 and all the parity nodes.
nodes.add(dn);
}
newNodes.add(nodes.get(i));
}

pipeline = Pipeline.newBuilder(pipeline)
.setReplicationConfig(StandaloneReplicationConfig
.getInstance(HddsProtos.ReplicationFactor.THREE))
.setNodes(newNodes)
.setNodes(nodes)
.build();

boolean success = false;
Expand Down