HDDS-7751. Volume quota must have all bucket quota set #4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sadanand48 @ChenSammi Please review |
sadanand48
reviewed
Jan 10, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @sumitagrawl for the patch, looks good overall, we should probably document this in apache docs .
...manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeSetQuotaRequest.java
Show resolved
Hide resolved
...manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeSetQuotaRequest.java
Outdated
Show resolved
Hide resolved
...e-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
Show resolved
Hide resolved
Contributor
|
LGTM, the acceptance test failures look related though. |
Contributor
|
The patch LGTM. Thanks @sumitagrawl for working on this. |
sadanand48
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
HDDS-7751
How was this patch tested?
Patch is tested with UT and E2E scenario