HDDS-7760. Let ContainerDataConstructor extend SafeConstructor #4162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jan 9, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @rohit-kb for working on this.
I think we also need to update new Yaml calls in a few places, passing SafeConstructor instance:
Contributor
Author
|
thanks @adoroszlai, just want to know a little about the role of SafeConstructor instance in Yaml object creations. |
adoroszlai
reviewed
Jan 10, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @rohit-kb for updating the patch.
| options.setPrettyFlow(true); | ||
| options.setDefaultFlowStyle(DumperOptions.FlowStyle.FLOW); | ||
| Yaml yaml = new Yaml(options); | ||
| Yaml yaml = new Yaml(new SafeConstructor(new LoaderOptions()), new Representer(options), options); |
Contributor
There was a problem hiding this comment.
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java
62: Line is longer than 80 characters (found 102).
|
|
||
| try { | ||
| Yaml yaml = new Yaml(); | ||
| Yaml yaml = new Yaml(new SafeConstructor(new LoaderOptions())); |
Contributor
There was a problem hiding this comment.
Looks like this causes test failures:
Tests run: 5, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 0.268 s <<< FAILURE! - in org.apache.hadoop.hdds.scm.net.TestYamlSchemaLoader
Can you please check?
Contributor
Author
There was a problem hiding this comment.
thanks for the review, looking into it
This reverts commit cacbccd.
adoroszlai
changed the title
adoroszlai
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Finding and replacing Constructor() class of snakeyaml with SafeConstructor() due to CVE-2022-1471
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7760