HDDS-7705. Fix OM Bootstrap request #4160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OM Bootstrap request failed with "Unknown protocol"
Contributor
|
@aswinshakil @duongkame can you'll please take a look? |
Cyrill
force-pushed
the
feature/HDDS-7705
branch
from
97e29b4 to
12176c9
Compare
adoroszlai
approved these changes
Jan 10, 2023
duongkame
approved these changes
Jan 10, 2023
Contributor
|
Thanks @Cyrill for the fix, @duongkame for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaced OMAdminProtocolPB protocolName with a proper class name. The existing one does not exist and leads to "Unknown protocol" error, which does not allow to add a new OM to the existing cluster.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7705
How was this patch tested?
Manually tested, with the fix a new OM is able to join the existing cluster.