HDDS-7603. Enable Erasure coding and encryption flag on FileStatus for ofs #4060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jojochuang Please take a look at the changes made. |
jojochuang
requested changes
Dec 9, 2022
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
@swamirishi the test testListStatusWithIntermediateDirWithECEnabled that you added failed in the check.
jojochuang
reviewed
Dec 9, 2022
| fileStatusAdapter.getGroup(), | ||
| fileStatusAdapter.getSymlink(), | ||
| fileStatusAdapter.getPath(), | ||
| false, |
Contributor
There was a problem hiding this comment.
This field is supposed to be a boolean "hasAcl".
This is unrelated, but I think once we are able to probe the external authorization provider for its ACL, we will be able to implement this field.
jojochuang
approved these changes
Dec 9, 2022
...onefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java
Show resolved
Hide resolved
Contributor
|
Thx @swamirishi for the quick iteration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable Erasure coding & encryption flag on fileStatus for ofs
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7603
How was this patch tested?
Unit Test case