HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well. #4042

devmadhuu · 2022-12-05T07:44:23Z

Currently, the /namsepace/summary endpoint carries only count data. Since it is a summary endpoint at the path level, we could make it more useful with other information as well.

Sample volume and bucket summary API responses

For volumes, we can add fields in OzoneVolume:

{
	"path": "/s3v",
	"type": "VOLUME",
	"counts": {
		"volumes": 0,
		"buckets": 1,
		"directories": 3,
		"object-store-prefixes": 0,
		"keys": 2
	},
	"dbinfo": {
		"metadata": {},
		"name": "s3v",
		"admin": "hadoop",
		"owner": "hadoop",
		"quotaInBytes": -1,
		"quotaInNamespace": -1,
		"usedNamespace": 1,
		"creationTime": "2021-07-27T18:21:40.251Z",
		"modificationTime": "2021-07-27T18:21:40.251Z",
		"acls": []
	},
	"status": "OK"
}

For buckets, we can add fields in OzoneBucket:

{
	"path": "/s3v/s3bucket",
	"type": "BUCKET",
	"counts": {
		"volumes": 0,
		"buckets": 0,
		"directories": 3,
		"object-store-prefixes": 0,
		"keys": 20
	},
	"dbinfo": {
		"metadata": {
			"ozone.om.metadata.layout": "PREFIX",
			"ozone.om.enable.filesystem.paths": "true"
		},
		"volumeName": "s3v",
		"name": "s3bucket",
		"storageType": "DISK",
		"versioning": false,
		"usedBytes": 536870912,
		"usedNamespace": 2,
		"creationTime": "2021-07-27T19:33:54.574Z",
		"modificationTime": "2021-07-27T19:33:54.574Z",
		"encryptionKeyName": null,
		"sourceVolume": null,
		"sourceBucket": null,
		"quotaInBytes": -1,
		"quotaInNamespace": -1
	},
	"status": "OK"
}

Some refactoring of existing code also been done to improve the structuring of API response. All counts related information has been grouped under "CountStats" and "dbInfo" information is added extra for detailed object information picked up from RocksDB for the path for which name space summary is generated.

https://issues.apache.org/jira/browse/HDDS-5541

Patch is tested with writing and executing Junit test cases inside "TestNSSummaryEndpointWithLegacy" and "TestNSSummaryEndpointWithFSO"

…the entity as well.

devmadhuu · 2022-12-05T07:44:42Z

@smengcl @dombizita , pls review

…the entity as well.

kerneltime · 2022-12-05T17:29:04Z

@swamirishi @aswinshakil can you please take a look?

hemantk-12 · 2022-12-07T00:27:43Z

...tegration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManagerFSO.java

    Assert.assertSame(entity.getEntityType(), EntityType.DIRECTORY);
-    Assert.assertEquals(1, entity.getNumTotalKey());
-    Assert.assertEquals(0, entity.getNumTotalDir());
+    Assert.assertEquals(1, entity.getCountStats().getNumTotalKey());


Why aren't we asserting getNumVolume() and getNumBucket() here?

Thanks @hemantk-12 for review. Changes done. Pls re-review. This was existing case, I added those missing as you mentioned.

hemantk-12 · 2022-12-07T00:36:47Z

...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketEntityHandler.java

+    CountStats countStats = new CountStats(
+        -1, -1,
+        getTotalDirCount(bucketObjectId), getTotalKeyCount(bucketObjectId));
+    NamespaceSummaryResponse namespaceSummaryResponse =


Suggested change

NamespaceSummaryResponse namespaceSummaryResponse =

return NamespaceSummaryResponse.newBuilder()

.setEntityType(EntityType.BUCKET)

.setCountStats(countStats)

.setObjectDBInfo(getBucketObjDbInfo(names))

.setStatus(ResponseStatus.OK)

.build();

Thanks @hemantk-12 for review. Changes done. Pls re-review.

hemantk-12 · 2022-12-07T00:47:58Z

...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketEntityHandler.java

+        getBucketKey(volName, bucketName);
+    OmBucketInfo omBucketInfo =
+        getOmMetadataManager().getBucketTable().getSkipCache(bucketKey);
+    BucketObjectDBInfo bucketObjectDBInfo = new BucketObjectDBInfo();


Create a constructor or a builder which takes OmBucketInfo in BucketObjectDBInfo. Something like this. This way encapsulation will be preserved.

public BucketObjectDBInfo(OmBucketInfo omBucketInfo) { this.metadata = omBucketInfo.getMetadata(); this.volumeName = omBucketInfo.getVolumeName(); this.name = omBucketInfo.getBucketName(); this.quotaInBytes = omBucketInfo.getQuotaInBytes(); this.quotaInNamespace = omBucketInfo.getQuotaInNamespace(); this.usedNamespace = omBucketInfo.getUsedNamespace(); this.creationTime = omBucketInfo.getCreationTime(); this.modificationTime = omBucketInfo.getModificationTime(); this.acls = omBucketInfo.getAcls(); this.sourceBucket = omBucketInfo.getSourceBucket(); this.sourceVolume = omBucketInfo.getSourceVolume(); this.encryptionKeyInfo = omBucketInfo.getEncryptionKeyInfo(); this.versioningEnabled = omBucketInfo.getIsVersionEnabled(); this.storageType = omBucketInfo.getStorageType(); this.defaultReplicationConfig = omBucketInfo.getDefaultReplicationConfig(); this.bucketLayout = omBucketInfo.getBucketLayout(); this.owner = omBucketInfo.getOwner(); }

Builder would be preferred tho.

Thanks @hemantk-12 for review. Changes done. Pls re-review.

hemantk-12 · 2022-12-07T01:28:06Z

...e/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/DirectoryEntityHandler.java

+  private ObjectDBInfo getDirectoryObjDbInfo(String[] names)
+      throws IOException {
+    OmDirectoryInfo dirInfo = getBucketHandler().getDirInfo(names);
+    ObjectDBInfo objectDBInfo = new ObjectDBInfo();


Same as BucketObjectDBInfo, create constructor or builder which takes OmDirectoryInfo and create ObjectDBInfo object.

Thanks @hemantk-12 for review. Changes done. Pls re-review.

hemantk-12 · 2022-12-07T01:29:05Z

...p-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/KeyEntityHandler.java

+  private ObjectDBInfo getKeyDbObjectInfo(String[] names)
+      throws IOException {
+    OmKeyInfo keyInfo = getBucketHandler().getKeyInfo(names);
+    KeyObjectDBInfo keyObjectDBInfo = new KeyObjectDBInfo();


Same as BucketObjectDBInfo, create constructor or builder which takes OmKeyInfo and create KeyObjectDBInfo object.

Thanks @hemantk-12 for review. Changes done. Pls re-review.

hemantk-12 · 2022-12-07T01:30:08Z

...-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/RootEntityHandler.java

+    OmPrefixInfo omPrefixInfo =
+        getOmMetadataManager().getPrefixTable().
+            getSkipCache(OzoneConsts.OM_KEY_PREFIX);
+    ObjectDBInfo objectDBInfo = new ObjectDBInfo();


Same as BucketObjectDBInfo, create constructor or builder which takes OmPrefixInfo and create ObjectDBInfo object.

hemantk-12 · 2022-12-07T01:31:07Z

...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/VolumeEntityHandler.java

+    String dbVolumeKey = getOmMetadataManager().getVolumeKey(names[0]);
+    OmVolumeArgs volumeArgs =
+        getOmMetadataManager().getVolumeTable().getSkipCache(dbVolumeKey);
+    VolumeObjectDBInfo objectDBInfo = new VolumeObjectDBInfo();


Same as BucketObjectDBInfo, create constructor or builder which takes OmVolumeArgs and create VolumeObjectDBInfo object.

Thanks @hemantk-12 for review. Changes done. Pls re-review.

hemantk-12 · 2022-12-07T01:35:50Z

...e/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java

+    Assert.assertEquals(2, rootResponseObj.getCountStats().getNumVolume());
+    Assert.assertEquals(4, rootResponseObj.getCountStats().getNumBucket());
+    Assert.assertEquals(5, rootResponseObj.getCountStats().getNumTotalDir());
+    Assert.assertEquals(10, rootResponseObj.getCountStats().getNumTotalKey());


This is a repetitive code. I think moving this to a function would be nicer.

Thanks @hemantk-12 for review. Changes done. Pls re-review.

I don't think this is addressed.

My bad, it has been fixed.

hemantk-12 · 2022-12-07T01:38:06Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+  @JsonProperty("replicationConfigInfo")
+  private DefaultReplicationConfig defaultReplicationConfig;
+
+  /** source volume. */


Java doc comments, like this, don't provide any information as such. I would recommend to remove obvious comments like this everywhere.

Thanks @hemantk-12 for review. Changes done. Pls re-review.

…the entity as well.

hemantk-12 · 2022-12-07T19:38:02Z

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/NSSummaryEndpoint.java

    if (!isInitializationComplete()) {
      namespaceSummaryResponse =
-          new NamespaceSummaryResponse(EntityType.UNKNOWN);
+          NamespaceSummaryResponse.newBuilder().


Suggested change

NamespaceSummaryResponse.newBuilder().

NamespaceSummaryResponse.newBuilder()

.setEntityType(EntityType.UNKNOWN)

.setStatus(ResponseStatus.INITIALIZING)

.build();

@hemantk-12 - this is fixed. pls re-review.

hemantk-12 · 2022-12-07T20:10:53Z

...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/BucketEntityHandler.java

+    return
+        NamespaceSummaryResponse.newBuilder()
+            .setEntityType(EntityType.BUCKET)
+            .setCountStats(countStats)
+            .setObjectDBInfo(getBucketObjDbInfo(names))
+            .setStatus(ResponseStatus.OK)
+            .build();


It could be in one line. Please change it everywhere.

Suggested change

return

NamespaceSummaryResponse.newBuilder()

.setEntityType(EntityType.BUCKET)

.setCountStats(countStats)

.setObjectDBInfo(getBucketObjDbInfo(names))

.setStatus(ResponseStatus.OK)

.build();

return NamespaceSummaryResponse.newBuilder()

.setEntityType(EntityType.VOLUME)

.setCountStats(countStats)

.setObjectDBInfo(getVolumeObjDbInfo(names))

.setStatus(ResponseStatus.OK)

.build();

@hemantk-12 - this is fixed. pls re-review.

hemantk-12 · 2022-12-07T20:33:15Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+
+  }
+
+  public BucketObjectDBInfo(Builder b) {


This is not how builder pattern works. Please change all the builder to this way.

Suggested change

public BucketObjectDBInfo(Builder b) {

public BucketObjectDBInfo(Map<String, String> metadata,

String name,

String volumeName,

StorageType storageType,

boolean isVersioningEnabled,

BucketEncryptionKeyInfo bekInfo,

DefaultReplicationConfig defaultReplicationConfig,

String sourceVolume,

String sourceBucket,

BucketLayout bucketLayout,

String owner,

long quotaInBytes,

long quotaInNamespace,

long usedNamespace,

long creationTime,

long modificationTime,

List<OzoneAcl> acls) {

super.setMetadata(metadata);

super.setName(name);

super.setQuotaInBytes(quotaInBytes);

super.setQuotaInNamespace(quotaInNamespace);

super.setUsedNamespace(usedNamespace);

super.setCreationTime(creationTime);

super.setModificationTime(modificationTime);

super.setAcls(acls);

this.volumeName = volumeName;

this.sourceBucket = sourceVolume;

this.sourceVolume = sourceBucket;

this.isVersioningEnabled = isVersioningEnabled;

this.storageType = storageType;

this.defaultReplicationConfig = defaultReplicationConfig;

this.bucketLayout = bucketLayout;

this.owner = owner;

this.bekInfo = bekInfo;

}

More: https://www.baeldung.com/java-builder-pattern-freebuilder

@hemantk-12 - there can be multiple ways to implement builder pattern. We should just make sure that OOPS principles being followed. You may want to look below link as well.

https://www.geeksforgeeks.org/builder-pattern-in-java/

@hemantk-12 - As discussed, implemented with plain constructor Pls re-review.

hemantk-12 · 2022-12-07T20:33:49Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+   * Builder for BucketObjectDBInfo.
+   */
+  @SuppressWarnings("checkstyle:hiddenfield")
+  public static final class Builder {


Suggested change

public static final class Builder {

public static class Builder {

private final OmBucketInfo omBucketInfo;

public Builder(OmBucketInfo omBucketInfo) {

this.omBucketInfo = omBucketInfo;

}

public BucketObjectDBInfo build() {

if (this.omBucketInfo == null) {

return new BucketObjectDBInfo();

}

return new BucketObjectDBInfo(omBucketInfo.getMetadata(),

omBucketInfo.getBucketName(),

omBucketInfo.getVolumeName(),

omBucketInfo.getStorageType(),

omBucketInfo.getIsVersionEnabled(),

omBucketInfo.getEncryptionKeyInfo(),

omBucketInfo.getDefaultReplicationConfig(),

omBucketInfo.getSourceVolume(),

omBucketInfo.getSourceBucket(),

omBucketInfo.getBucketLayout(),

omBucketInfo.getOwner(),

omBucketInfo.getQuotaInBytes(),

omBucketInfo.getQuotaInNamespace(),

omBucketInfo.getUsedNamespace(),

omBucketInfo.getCreationTime(),

omBucketInfo.getModificationTime(),

omBucketInfo.getAcls());

}

}

@hemantk-12 - This is just a specific pattern you mentioned. Builder pattern can be written in many ways. We can discuss over this in Slack channel. I have pinged you. You can let me know when you are free to discuss.

@hemantk-12 - As discussed, implemented with plain constructor Pls re-review.

hemantk-12 · 2022-12-07T20:35:07Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+    return volumeName;
+  }
+
+  public void setVolumeName(String volumeName) {


Why do we need setter? Is it for jackson serialization?

@hemantk-12 - yes it is needed for JSON serialization

hemantk-12 · 2022-12-07T20:39:20Z

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/ObjectDBInfo.java

+/**
+ * Encapsulates the low level volume/bucket/dir info.
+ */
+public class ObjectDBInfo {


Should we just call it ObjectInfo? Why DB in the name?

@hemantk-12 - It is because these attributes are very specific to what we save in RocksDB. Pls also you can go through JIRA details.

@hemantk-12 - As discussed, we have kept the name same as ObjectDBInfo. Pls re-review.

hemantk-12 · 2022-12-07T20:49:54Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+/**
+ * Encapsulates the low level bucket info.
+ */
+public class BucketObjectDBInfo extends ObjectDBInfo {


Is it really a subclass of ObjectDBInfo? Or you just did it because they share some common properties?

It also doesn't follow the correct hierarchy model.
Java doc comment says VolumeObjectDBInfo encapsulates the low level volume info, BucketObjectDBInfo encapsulates the low level bucket info and ObjectDBInfoEncapsulates the low level volume/bucket/dir info.

So hierarchy should be Volume -> Bucket -> Dir -> Key but according to your implementation Dir -> Volume, Bucket and Key. Which is wrong to me.

Please correct it. If you want to extract out common properties, create another class something CommonPropertyClass (Please come up with better name).

VolumeObjectDBInfo extands CommonPropertyClass BucketObjectDBInfo extands CommonPropertyClass ObjectDBInfo extands CommonPropertyClass KeyObjectDBInfo extands CommonPropertyClass

@hemantk-12 , thanks for your review. Here we don't have to follow that Volume -> Bucket -> Dir -> Key
Because this ObjectDBInfo is a parent class with common properties.
Because this is RocksDB object level info properties and I feel giving name as ObjectDBInfo is justifying name... as this is no specific objectDB info and attributes can be related to any object which is common... So either we can give name as CommonPropertyClass or ObjectDBInfo, how does it matter. It is just an implementation specific I believe.

Is it really a subclass of ObjectDBInfo? Or you just did it because they share some common properties?

It also doesn't follow the correct hierarchy model. Java doc comment says VolumeObjectDBInfo encapsulates the low level volume info, BucketObjectDBInfo encapsulates the low level bucket info and ObjectDBInfoEncapsulates the low level volume/bucket/dir info.

So hierarchy should be Volume -> Bucket -> Dir -> Key but according to your implementation Dir -> Volume, Bucket and Key. Which is wrong to me.

Please correct it. If you want to extract out common properties, create another class something CommonPropertyClass (Please come up with better name).

VolumeObjectDBInfo extands CommonPropertyClass BucketObjectDBInfo extands CommonPropertyClass ObjectDBInfo extands CommonPropertyClass KeyObjectDBInfo extands CommonPropertyClass

@hemantk-12 - As discussed, we have kept the name same as ObjectDBInfo. Pls re-review.

hemantk-12 · 2022-12-07T20:52:39Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+  @JsonProperty("owner")
+  private String owner;
+
+  public static BucketObjectDBInfo.Builder newBuilder() {


This is unnecessary function.

@hemantk-12 - I couldn't understand this. Pls elaborate why unnecessary.

Because new BucketObjectDBInfo.Builder(); can be used instead of BucketObjectDBInfo.newBuilder() . It is not providing any benefit.

If it is general pattern followed in the code base, please go ahead with it.

@hemantk-12 - As discussed, I have implemented without builder and with plain constructor. Pls re-review.

hemantk-12 · 2022-12-07T20:54:49Z

...e/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java

+    Assert.assertEquals(2, rootResponseObj.getCountStats().getNumVolume());
+    Assert.assertEquals(4, rootResponseObj.getCountStats().getNumBucket());
+    Assert.assertEquals(5, rootResponseObj.getCountStats().getNumTotalDir());
+    Assert.assertEquals(10, rootResponseObj.getCountStats().getNumTotalKey());


I don't think this is addressed.

…the entity as well.

hemantk-12

LGTM.

smengcl · 2022-12-21T20:22:10Z

...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java

+  @Override
+  public OmDirectoryInfo getDirInfo(String[] names) throws IOException {
+    return OmDirectoryInfo.newBuilder()
+        .setName(names[2])


If names has less than 3 elements, iirc it throws ArrayIndexOutOfBoundsException which is a RuntimeException and won't be caught by IOException.

Add a Preconditions.checkArgument check here?

@smengcl - this check is not needed here as above code flow hits only when the path will be directory else not.

could you explain more, what guarantees that we can't call this getDirInfo method only when the path is a directory? this is inside BucketHandler and a legacy bucket doesn't necessarily have a directory inside.

@devmadhuu I get that the only caller (at the moment) calling this method won't cause issues. I'm fine with either adding or not adding the check but I would prefer the former.

Same goes for the method in FSOBucketHandler.

@dombizita - getDirInfo method has caller only through DirectoryEntityHandler and call stack for DirectoryEntityHandler will be determined after validating the path , if path is directory, then only DirectoryEntityHandler will be returned by EntityHandler.getEntityHandler , so there is no way the current code flow will hit getDirInfo method if path is not directory. First two indexes will be taken by Volume and Bucket in path and 3rd index will be surely a directory. Please check the caller hierarchy of this method. We can have zoom call to explain by sharing my screen.

I get that currently this is only called when it is guaranteed that the path is a directory. but if someone later adds something and doesn't know how this method works the scenario can happen which @smengcl wrote above. all the classes that are extending the EntityHandler abstract class can do a OmDirectoryInfo omDirectoryInfo = getBucketHandler().getDirInfo(names), even if the names length is less than 3. I am also fine with either way, just wanted to clarify what I meant.

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/CountStats.java

smengcl

Thanks @devmadhuu for working on this. Overall looks fine.

…the entity as well.

…tion on the entity as well." This reverts commit 4b07e59.

…the entity as well.

dombizita

thanks for this useful improvement @devmadhuu, I added few comment inline, beside that it looks good to me.

dombizita · 2023-01-09T14:16:01Z

...zone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java

+  @Override
+  public OmDirectoryInfo getDirInfo(String[] names) throws IOException {
+    return OmDirectoryInfo.newBuilder()
+        .setName(names[2])


could you explain more, what guarantees that we can't call this getDirInfo method only when the path is a directory? this is inside BucketHandler and a legacy bucket doesn't necessarily have a directory inside.

dombizita · 2023-01-09T14:30:30Z

...op-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java

+ * Encapsulates the low level bucket info.
+ */
+public class BucketObjectDBInfo extends ObjectDBInfo {
+  @JsonProperty("volumeName")


what is the difference between volumeName and sourceVolume (in line 52)?

sourceVolume is used for bucket link iirc.

ozone/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java

Line 4306 in 85e7cd1

Pair.of(info.getSourceVolume(), info.getSourceBucket()),

what is the difference between volumeName and sourceVolume (in line 52)?

@dombizita - SourceVolume is used if bucket is a symbolic link.

…the entity as well.

dombizita · 2023-01-11T09:18:12Z

thanks for updating your patch @devmadhuu, it looks good to me!

siddhantsangwan · 2023-01-11T10:16:46Z

@devmadhuu Thanks for the contribution. Thanks everyone for reviewing. Merging this now that we have approvals.

HDDS-5541. Namespace summary endpoint can carry basic information on …

8125de8

…the entity as well.

HDDS-5541. Namespace summary endpoint can carry basic information on …

a11acd6

…the entity as well.

kerneltime requested a review from smengcl December 5, 2022 17:28

hemantk-12 reviewed Dec 7, 2022

View reviewed changes

HDDS-5541. Namespace summary endpoint can carry basic information on …

7e64e58

…the entity as well.

hemantk-12 reviewed Dec 7, 2022

View reviewed changes

HDDS-5541. Namespace summary endpoint can carry basic information on …

4045ed3

…the entity as well.

hemantk-12 approved these changes Dec 8, 2022

View reviewed changes

smengcl reviewed Dec 21, 2022

View reviewed changes

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/CountStats.java Outdated Show resolved Hide resolved

smengcl reviewed Dec 21, 2022

View reviewed changes

Devesh Singh added 3 commits December 22, 2022 11:55

HDDS-5541. Namespace summary endpoint can carry basic information on …

4b07e59

…the entity as well.

Revert "HDDS-5541. Namespace summary endpoint can carry basic informa…

50d7eb5

…tion on the entity as well." This reverts commit 4b07e59.

HDDS-5541. Namespace summary endpoint can carry basic information on …

b7d5a95

…the entity as well.

dombizita reviewed Jan 9, 2023

View reviewed changes

smengcl approved these changes Jan 10, 2023

View reviewed changes

HDDS-5541. Namespace summary endpoint can carry basic information on …

7d51838

…the entity as well.

siddhantsangwan merged commit de53086 into apache:master Jan 11, 2023

-  public BucketObjectDBInfo(Builder b) {
+  public BucketObjectDBInfo(Map<String, String> metadata,
+                            String name,
+                            String volumeName,
+                            StorageType storageType,
+                            boolean isVersioningEnabled,
+                            BucketEncryptionKeyInfo bekInfo,
+                            DefaultReplicationConfig defaultReplicationConfig,
+                            String sourceVolume,
+                            String sourceBucket,
+                            BucketLayout bucketLayout,
+                            String owner,
+                            long quotaInBytes,
+                            long quotaInNamespace,
+                            long usedNamespace,
+                            long creationTime,
+                            long modificationTime,
+                            List<OzoneAcl> acls) {
+    super.setMetadata(metadata);
+    super.setName(name);
+    super.setQuotaInBytes(quotaInBytes);
+    super.setQuotaInNamespace(quotaInNamespace);
+    super.setUsedNamespace(usedNamespace);
+    super.setCreationTime(creationTime);
+    super.setModificationTime(modificationTime);
+    super.setAcls(acls);
+    this.volumeName = volumeName;
+    this.sourceBucket = sourceVolume;
+    this.sourceVolume = sourceBucket;
+    this.isVersioningEnabled = isVersioningEnabled;
+    this.storageType = storageType;
+    this.defaultReplicationConfig = defaultReplicationConfig;
+    this.bucketLayout = bucketLayout;
+    this.owner = owner;
+    this.bekInfo = bekInfo;
+  }

-  public static final class Builder {
+  public static class Builder {
+    private final OmBucketInfo omBucketInfo;
+    public Builder(OmBucketInfo omBucketInfo) {
+      this.omBucketInfo = omBucketInfo;
+    }
+    public BucketObjectDBInfo build() {
+      if (this.omBucketInfo == null) {
+        return new BucketObjectDBInfo();
+      }
+      return new BucketObjectDBInfo(omBucketInfo.getMetadata(),
+          omBucketInfo.getBucketName(),
+          omBucketInfo.getVolumeName(),
+          omBucketInfo.getStorageType(),
+          omBucketInfo.getIsVersionEnabled(),
+          omBucketInfo.getEncryptionKeyInfo(),
+          omBucketInfo.getDefaultReplicationConfig(),
+          omBucketInfo.getSourceVolume(),
+          omBucketInfo.getSourceBucket(),
+          omBucketInfo.getBucketLayout(),
+          omBucketInfo.getOwner(),
+          omBucketInfo.getQuotaInBytes(),
+          omBucketInfo.getQuotaInNamespace(),
+          omBucketInfo.getUsedNamespace(),
+          omBucketInfo.getCreationTime(),
+          omBucketInfo.getModificationTime(),
+          omBucketInfo.getAcls());
+    }
+  }

HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well. #4042

HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well. #4042

Uh oh!

Conversation

devmadhuu commented Dec 5, 2022 • edited by smengcl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devmadhuu commented Dec 5, 2022

Uh oh!

kerneltime commented Dec 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

devmadhuu commented Dec 5, 2022 •

edited by smengcl

Loading