HDDS-7587. Update NOTICE and LICENSE in license/bin/ #4039
Conversation
|
hi, @szetszwo, could you help review this PR? After this is done we will start Ozone RC2. |
kaijchen
changed the title
|
@captainzmc , I am traveling so that I may not be able to review this for a few days. @kaijchen, would you be able to review this? |
|
The current change looks good. @szetszwo do we need to check licenses for indirect dependencies also? |
@kaijchen , the above is quoted from https://infra.apache.org/licensing-howto.html |
|
@captainzmc , I am checking the license and notice.
|
There was a problem hiding this comment.
@captainzmc , thanks a lot for working on this! Tried the following:
- Generate the release tarball and untar it.
- Get the jar list:
ls share/ozone/lib/ > jar.txt - Check the license for each jar.
The jar list has 267 lines. I checked 144 lines so far. Got the following changes: https://issues.apache.org/jira/secure/attachment/13053665/4039_review.patch
|
Thanks @szetszwo for the patch provided. I will continue to check all jars and update the LICENSE. |
|
@captainzmc , sure, we can upgrade Ratis later. Will continue checking the license tomorrow. |
|
@captainzmc , just have check all the remaining licenses; see https://issues.apache.org/jira/secure/attachment/13053715/4039_review2.patch |
|
Thanks @szetszwo! I had updated LICENSE.txt. |
We already have diff --git a/hadoop-ozone/dist/src/main/license/bin/licenses/NOTICE-ratis-thirtparty-misc.txt b/hadoop-ozone/dist/src/main/license/bin/licenses/NOTICE-ratis-thirdparty-misc.txt
similarity index 94%
rename from hadoop-ozone/dist/src/main/license/bin/licenses/NOTICE-ratis-thirtparty-misc.txt
rename to hadoop-ozone/dist/src/main/license/bin/licenses/NOTICE-ratis-thirdparty-misc.txt
index a4915c6ae..c47cb75fe 100644
--- a/hadoop-ozone/dist/src/main/license/bin/licenses/NOTICE-ratis-thirtparty-misc.txt
+++ b/hadoop-ozone/dist/src/main/license/bin/licenses/NOTICE-ratis-thirdparty-misc.txt
@@ -1,5 +1,5 @@
Apache Ratis
-Copyright 2021 The Apache Software Foundation
+Copyright 2017-2022 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
@@ -316,25 +316,3 @@ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-----------------------------------------------------------------------
-This product uses the dropwizard-hadoop-metrics2.
-
-Copyright 2016 Josh Elser
-
-Licensed under the Apache License v2.0
-
------------------------------------------------------------------------
-This product uses https://github.com/mbocek/docker-ganglia/
-
-Contributed by Michal Bocek
-
-Licensed under the Apache License v2.0
-https://github.com/mbocek/docker-ganglia/blob/master/LICENSE
-
------------------------------------------------------------------------
-This product uses https://github.com/graphite-project/docker-graphite-statsd
-
-Copyright (c) 2013-2016 Nathan Hopkins
-
-Licensed under the MIT License |
|
Thanks @szetszwo for the advice, Just had updated the ratis-thirdparty NOTICE. |
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
|
Thanks @captainzmc and @szetszwo for checking all the dependencies. |
* update NOTICE and LICENSE in license/bin/
3 participants
What changes were proposed in this pull request?
We had fix NOTICE and LICENSE in HDDS-7567 and HDDS-7568 in src. We should also update the NOTICE and LICENSES in license/bin/.
In this patch, we mainly update the LICENSE and NOTICE that need to be modified, and delete the not needed (Some are no longer used in the project, and some need to change the format from html to txt).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7587
How was this patch tested?
No need.