HDDS-7464. Container Report at SCM is not coming separately for ICR and FCR in prometheus endpoint #4035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd FCR in prometheus endpoint
…nd FCR in prometheus endpoint
Contributor
Author
|
@ChenSammi Plz review, now annotation is used for this to handle |
ChenSammi
reviewed
Dec 6, 2022
| /** | ||
| * Metrics util for metrics. | ||
| */ | ||
| public final class MetricsUtil { |
Contributor
There was a problem hiding this comment.
Instead of creating a new package, please move this class to org.apache.hadoop.hdds.utils package.
The rest looks good to me.
…nd FCR in prometheus endpoint
sumitagrawl
requested review from
ChenSammi
and removed request for
kerneltime
ChenSammi
approved these changes
Dec 6, 2022
Galsza
pushed a commit
to Galsza/ozone
that referenced
this pull request
Dec 7, 2022
…nd FCR in prometheus endpoint (apache#4035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Event Queue metrics is not reported properly to prometheus, as classname is same for all reports. As HDDS metrics, annotation is used to identify metric name for prometheus, but if not present make use of classname.
As change,
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7464
How was this patch tested?
Event queue metrics reported:
FCR:
ICR:
Earlier, event_queue_** reports were not coming as prefix. Its coming directly with class name.