HDDS-7565. FSO purge directory for old bucket can update quota for new bucket

[sumitagrawl]

What changes were proposed in this pull request?

BucketId comparision is added if key/folder belongs to same bucket or not for updating quota

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7565

How was this patch tested?

Patch is tested with Unit case, and End to End scenario for quota update

[kerneltime]

cc @duongkame

[neils-dev]

Thanks @sumitagrawl for this PR. Looking at the scenario described in the jira. I haven't been able to reproduce the error. Currently, I'm doing the following and expecting the error,

bash-4.2$ ozone sh volume create /vol1
bash-4.2$ ozone sh volume setquota --namespace-quota 1 /vol1
bash-4.2$ ozone sh bucket create --layout FILE_SYSTEM_OPTIMIZED /vol1/bucket1
bash-4.2$ ozone sh bucket setquota --space-quota=10000000 /vol1/bucket1
bash-4.2$ ozone freon omkg -b bucket1 -v vol1
bash-4.2$ ozone fs -rm -r -skipTrash /vol1/bucket1

bash-4.2$ ozone sh bucket create --layout FILE_SYSTEM_OPTIMIZED /vol1/bucket1

When the bucket is re-created I do not see a problem with namespace nor size quotas for volume and bucket. Why is the error not present?

[sumitagrawl]

@neils-dev Need to observe quota update in bucket info for changes, I have run above and then captured bucket info with quota,

1. bucket info showing usedNamesapce "1000"

sumitagrawal@sumitagrawal-MBP16 bin % ./ozone sh bucket info /vol1/bucket1                           
2022-12-12 10:35:13,513 WARN  util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(60)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
{
  "metadata" : { },
  "volumeName" : "vol1",
  "name" : "bucket1",
  "storageType" : "DISK",
  "versioning" : false,
  "usedBytes" : 0,
  "usedNamespace" : 1000,
  "creationTime" : "2022-12-12T04:58:03.668Z",
  "modificationTime" : "2022-12-12T05:04:20.651Z",
  "quotaInBytes" : 10737418240,
  "quotaInNamespace" : -1,
  "bucketLayout" : "FILE_SYSTEM_OPTIMIZED",
  "link" : false,
  "replicationConfig" : {
    "replicationFactor" : "ONE",
    "requiredNodes" : 1,
    "replicationType" : "RATIS"
  }
}

2. remove bucket recursive and recreate a bucket and check used namespace (its "0")

sumitagrawal@sumitagrawal-MBP16 bin % ./ozone fs -rm -r -skipTrash /vol1/bucket1
2022-12-12 10:35:42,135 WARN  util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(60)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
Deleted /vol1/bucket1

sumitagrawal@sumitagrawal-MBP16 bin % ./ozone sh bucket create --layout FILE_SYSTEM_OPTIMIZED /vol1/bucket1
2022-12-12 10:35:53,211 WARN  util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(60)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2022-12-12 10:35:53,827 INFO  rpc.RpcClient (RpcClient.java:createBucket(691)) - Creating Bucket: vol1/bucket1, with bucket layout FILE_SYSTEM_OPTIMIZED, sumitagrawal as owner, Versioning false, Storage Type set to DISK and Encryption set to false 
sumitagrawal@sumitagrawal-MBP16 bin % ./ozone sh bucket info /vol1/bucket1                           
2022-12-12 10:35:59,880 WARN  util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(60)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
{
  "metadata" : { },
  "volumeName" : "vol1",
  "name" : "bucket1",
  "storageType" : "DISK",
  "versioning" : false,
  "usedBytes" : 0,
  "usedNamespace" : 0,
  "creationTime" : "2022-12-12T05:05:53.838Z",
  "modificationTime" : "2022-12-12T05:05:53.838Z",
  "quotaInBytes" : -1,
  "quotaInNamespace" : -1,
  "bucketLayout" : "FILE_SYSTEM_OPTIMIZED",
  "owner" : "sumitagrawal",
  "link" : false
}

3. After some time, its observed namespace is changed to "-1000" which is after purge of directory is completed. This should not happen for the newly created bucket.

sumitagrawal@sumitagrawal-MBP16 bin % ./ozone sh bucket info /vol1/bucket1
2022-12-12 10:38:01,114 WARN  util.NativeCodeLoader (NativeCodeLoader.java:<clinit>(60)) - Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
{
  "metadata" : { },
  "volumeName" : "vol1",
  "name" : "bucket1",
  "storageType" : "DISK",
  "versioning" : false,
  "usedBytes" : 0,
  "usedNamespace" : -1000,
  "creationTime" : "2022-12-12T05:05:53.838Z",
  "modificationTime" : "2022-12-12T05:05:53.838Z",
  "quotaInBytes" : -1,
  "quotaInNamespace" : -1,
  "bucketLayout" : "FILE_SYSTEM_OPTIMIZED",
  "owner" : "sumitagrawal",
  "link" : false
}
sumitagrawal@sumitagrawal-MBP16 bin % 

[neils-dev]

Thanks @sumitagrawl for the patch and the changes. +1
Thanks @kerneltime for reviewing this PR.