HDDS-7560. Placement Policy Interface changes to handle Overreplication #4014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Before creating a pull request please make sure that you get a green CI run in your fork. Checkstyle is fairly quick, painless to run even locally: |
sodonnel
reviewed
Jan 4, 2023
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java
Show resolved
Hide resolved
sodonnel
reviewed
Jan 4, 2023
...p-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java
Show resolved
Hide resolved
sodonnel
reviewed
Jan 6, 2023
| for (ContainerReplica replica:replicas) { | ||
| Integer replicaId = replica.getReplicaIndex(); | ||
| Node placementGroup = getPlacementGroup(replica.getDatanodeDetails()); | ||
| if (!replicaIdMap.containsKey(replicaId)) { |
Contributor
There was a problem hiding this comment.
I think this can be simplified to:
replicaIdMap.computeIfAbsent(replicaID, k -> Sets.newHashSet()).add(replica);
And then line 554 can go away too.
Similar for the one below.
sodonnel
reviewed
Jan 6, 2023
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java
Show resolved
Hide resolved
sodonnel
reviewed
Jan 6, 2023
| replicaIdMap.get(replicaId).add(replica); | ||
| Map<Integer, Set<ContainerReplica>> placementGroupReplicaIDMap = | ||
| placementGroupReplicaIdMap.get(placementGroup); | ||
| placementGroupReplicaIDMap.compute(replicaId, |
Contributor
There was a problem hiding this comment.
I think this can be more concise with:
placementGroupReplicaIDMap.computeIfAbsent(replicaId, k -> Sets.newHashSet()).add(replica);
sodonnel
reviewed
Jan 6, 2023
| * the count for rack is reduced. | ||
| * The set of replicas computed are then returned by the function. | ||
| * @param replicas: Map of replicas with value signifying if | ||
| * replica can be copied |
Contributor
There was a problem hiding this comment.
This parameter is a Set not a map with value. I think this was copied from the earlier interface we worked on.
sodonnel
reviewed
Jan 9, 2023
...p-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java
Outdated
Show resolved
Hide resolved
sodonnel
reviewed
Jan 9, 2023
...p-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java
Show resolved
Hide resolved
sodonnel
reviewed
Jan 9, 2023
...p-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java
Show resolved
Hide resolved
sodonnel
reviewed
Jan 9, 2023
...p-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java
Show resolved
Hide resolved
Contributor
|
I think the logic looks good. I have just a few comments on the tests and a couple more tests to add and then we are good I think. |
sodonnel
reviewed
Jan 9, 2023
...p-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/TestSCMCommonPlacementPolicy.java
Show resolved
Hide resolved
sodonnel
approved these changes
Jan 9, 2023
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the review comments.
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 6, 2023
…on (apache#4014) (cherry picked from commit ed7c60c) Change-Id: Ie04cd0f671cacd2335658b891dbeba0ee7f71f28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Placement Policy Interface changes to handle Overreplication changes
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7560
How was this patch tested?
Unit test