Skip to content

HDDS-2756 Better logging and message for pipeline creation failure. #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timmylicheng wants to merge 1 commit into from
Closed

HDDS-2756 Better logging and message for pipeline creation failure. #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions ...server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,10 @@ boolean meetCriteria(DatanodeDetails datanodeDetails, int nodesRequired) {
boolean meet = (nodeManager.getPipelinesCount(datanodeDetails)
- pipelineNumDeductable) < heavyNodeCriteria;
if (!meet) {
LOG.info("Pipeline Placement: can't place more pipeline on heavy " +
"datanode： " + datanodeDetails.getUuid().toString() + " Heaviness: " +
nodeManager.getPipelinesCount(datanodeDetails) + " limit: " +
heavyNodeCriteria);
LOG.debug("Pipeline Placement: can't place more pipeline on heavy " +
"datanode： " + datanodeDetails.getUuid().toString() +
" Heaviness: " + nodeManager.getPipelinesCount(datanodeDetails) +
" limit: " + heavyNodeCriteria);
}
return meet;
}
Expand All @@ -144,17 +144,19 @@ List<DatanodeDetails> filterViableNodes(
int initialHealthyNodesCount = healthyNodes.size();
String msg;
if (initialHealthyNodesCount == 0) {
msg = "No healthy node found to allocate pipeline.";
msg = "No healthy nodes found to allocate pipeline.";
LOG.error(msg);
throw new SCMException(msg, SCMException.ResultCodes
.FAILED_TO_FIND_HEALTHY_NODES);
}

if (initialHealthyNodesCount < nodesRequired) {
msg = String.format("Not enough healthy nodes to allocate pipeline. %d "
LOG.warn("Not enough healthy nodes to allocate pipeline. %d "
+ " datanodes required. Found %d",
nodesRequired, initialHealthyNodesCount);
LOG.error(msg);
msg = String.format("Pipeline creation failed due to no sufficient" +
" healthy datanodes. Required %d. Found %d.",
nodesRequired, initialHealthyNodesCount);
throw new SCMException(msg,
SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
}
Expand All @@ -166,13 +168,15 @@ List<DatanodeDetails> filterViableNodes(
.collect(Collectors.toList());

if (healthyList.size() < nodesRequired) {
msg = String.format("Unable to find enough nodes that meet " +
LOG.debug("Unable to find enough nodes that meet " +
"the criteria that cannot engage in more than %d pipelines." +
" Nodes required: %d Found: %d, healthy nodes count in " +
"NodeManager: %d.",
heavyNodeCriteria, nodesRequired, healthyList.size(),
initialHealthyNodesCount);
LOG.error(msg);
msg = String.format("Pipeline creation failed due to not enough" +
" healthy datanodes after filter. Required %d. Found %d",
nodesRequired, initialHealthyNodesCount);
throw new SCMException(msg,
SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
}
Expand Down Expand Up @@ -229,8 +233,8 @@ public List<DatanodeDetails> getResultSet(
// First choose an anchor nodes randomly
DatanodeDetails anchor = chooseNode(healthyNodes);
if (anchor == null) {
LOG.error("Pipeline Placement: Unable to find the first healthy nodes " +
"that meet the criteria. Required nodes: {}, Found nodes: {}",
LOG.warn("Unable to find healthy nodes." +
" Required nodes: {}, Found nodes: {}",
nodesRequired, results.size());
throw new SCMException("Unable to find required number of nodes.",
SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE);
Expand All @@ -245,7 +249,7 @@ public List<DatanodeDetails> getResultSet(
healthyNodes, exclude,
nodeManager.getClusterNetworkTopologyMap(), anchor);
if (nodeOnDifferentRack == null) {
LOG.error("Pipeline Placement: Unable to find nodes on different racks " +
LOG.warn("Pipeline Placement: Unable to find nodes on different racks " +
" that meet the criteria. Required nodes: {}, Found nodes: {}",
nodesRequired, results.size());
throw new SCMException("Unable to find required number of nodes.",
Expand All @@ -269,7 +273,7 @@ public List<DatanodeDetails> getResultSet(
}

if (results.size() < nodesRequired) {
LOG.error("Pipeline Placement: Unable to find the required number of " +
LOG.warn("Unable to find the required number of " +
"healthy nodes that meet the criteria. Required nodes: {}, " +
"Found nodes: {}", nodesRequired, results.size());
throw new SCMException("Unable to find required number of nodes.",
Expand Down
1 change: 0 additions & 1 deletion ...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ public synchronized Pipeline createPipeline(ReplicationType type,
return pipeline;
} catch (IOException ex) {
metrics.incNumPipelineCreationFailed();
LOG.error("Pipeline creation failed.", ex);
throw ex;
} finally {
lock.writeLock().unlock();
Expand Down