Skip to content

HDDS-6615. EC: Improve write performance by pipelining encode and flush #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sodonnel merged 13 commits into from
Nov 30, 2022
Merged

HDDS-6615. EC: Improve write performance by pipelining encode and flush #3994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
71acfd9
refactor: writeDataCells
kaijchen Nov 22, 2022
af49a4e
refactor: commitStripeWrite
kaijchen Nov 22, 2022
9af2d2c
refactor: inline encodeAndWriteParityCells
kaijchen Nov 22, 2022
3b4c91c
refactor: flush data until stripe ready
kaijchen Nov 22, 2022
6239509
fix: do not convert exception in write
kaijchen Nov 22, 2022
61d7a09
refactor: flushStripeToDatanodes
kaijchen Nov 22, 2022
673460b
refactor: handleOutputStreamWrite
kaijchen Nov 22, 2022
6dbc784
refactor: replace ecChunkBufferCache under flush by thread local argu…
kaijchen Nov 22, 2022
6b3645c
feat: flush EC stripe in a separate thread
kaijchen Nov 22, 2022
d710aff
fix: check flush thread status while enqueue
kaijchen Nov 23, 2022
1a45526
Merge branch 'master' into HDDS-6615
kaijchen Nov 23, 2022
5deb2a6
fix: do not check isDone after offer EOFStripe
kaijchen Nov 23, 2022
5ceb26c
fix: fail fast if flush thread is dead
kaijchen Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ public enum ChecksumCombineMode {
tags = ConfigTag.CLIENT)
private int maxECStripeWriteRetries = 10;

@Config(key = "ec.stripe.queue.size",
defaultValue = "2",
description = "The max number of EC stripes can be buffered in client " +
" before flushing into datanodes.",
tags = ConfigTag.CLIENT)
private int ecStripeQueueSize = 2;

@Config(key = "exclude.nodes.expiry.time",
defaultValue = "600000",
description = "Time after which an excluded node is reconsidered for" +
Expand Down Expand Up @@ -288,6 +295,10 @@ public int getMaxECStripeWriteRetries() {
return this.maxECStripeWriteRetries;
}

public int getEcStripeQueueSize() {
return this.ecStripeQueueSize;
}

public long getExcludeNodesExpiryTime() {
return excludeNodesExpiryTime;
}
Expand Down
Loading