-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-7464. Container Report at SCM is not coming separately for ICR and FCR in prometheus endpoint #3979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nd FCR in prometheus endpoint
…nd FCR in prometheus endpoint
|
@ChenSammi Plz review |
|
@neils-dev @kerneltime @ChenSammi Please review |
|
Thanks @sumitagrawl for filing this jira. A general comment - on the subject of this jira, Container Report at SCM is not coming separately for ICR and FCR in prometheus endpoint . Metrics for the full container report, FCR and the incremental container reports, ICR appear to be collected separately with the Is this jira for adding additional metrics to be collected and published for FCR and ICR ? |
Its not about adding new metrics, Its about issue for reporting to prometheus. By default, prometheus endpoint takes classname as key and report metrics. |
|
Hi @sumitagrawl , I have gone through the existing code. It looks like both FCR and ICR are reported in prometheus. And both FCR and ICR event queue metrics are exposed through JMX too. I'm a little confused about this task. |
|
@ChenSammi But I have fixed for metrics related to EventQueue for ICR/FCR, this is part of FixedThreadPoolWithAffinityExecutor as earlier reported. Both are different. |
|
@ChenSammi Will create another PR with other implementation for this. |


What changes were proposed in this pull request?
Metrics classes seperated for ICR and FCR to report seperately for prometheus
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7464
How was this patch tested?