-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-7384. EC: ReplicationManager - implement deleting container handler #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
21ea074
HDDS-7384. EC: ReplicationManager - implement deleting container handler
97d6d6a
add check for DELETED state
e43e6ec
add updateContainerState in RM
f963d32
update test
7c4e96a
remove containerManager from TestEmptyContainerHandler
a49183a
remove unused exception
4870818
fix comments
7c189b3
triger CI
66b5eda
triger CI
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
...ava/org/apache/hadoop/hdds/scm/container/replication/health/DeletingContainerHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hdds.scm.container.replication.health; | ||
|
|
||
| import org.apache.hadoop.hdds.protocol.DatanodeDetails; | ||
| import org.apache.hadoop.hdds.protocol.proto.HddsProtos; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerID; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerInfo; | ||
| import org.apache.hadoop.hdds.scm.container.replication.ContainerCheckRequest; | ||
| import org.apache.hadoop.hdds.scm.container.replication.ContainerReplicaOp; | ||
| import org.apache.hadoop.hdds.scm.container.replication.ReplicationManager; | ||
| import org.apache.ratis.protocol.exceptions.NotLeaderException; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import java.util.Set; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * Class used in Replication Manager to handle the | ||
| * replicas of containers in DELETING State. | ||
| */ | ||
| public class DeletingContainerHandler extends AbstractCheck { | ||
| private final ReplicationManager replicationManager; | ||
|
|
||
| public static final Logger LOG = | ||
| LoggerFactory.getLogger(DeletingContainerHandler.class); | ||
|
|
||
| public DeletingContainerHandler(ReplicationManager replicationManager) { | ||
| this.replicationManager = replicationManager; | ||
| } | ||
|
|
||
| /** | ||
| * If the number of replicas of the container is 0, change the state | ||
| * of the container to Deleted, otherwise resend delete command if needed. | ||
| * @param request ContainerCheckRequest object representing the container | ||
| * @return false if the specified container is not in DELETING state, | ||
| * otherwise true. | ||
| */ | ||
| @Override | ||
| public boolean handle(ContainerCheckRequest request) { | ||
| ContainerInfo containerInfo = request.getContainerInfo(); | ||
| ContainerID cID = containerInfo.containerID(); | ||
| HddsProtos.LifeCycleState containerState = containerInfo.getState(); | ||
|
|
||
| if (containerState == HddsProtos.LifeCycleState.DELETED) { | ||
| return true; | ||
| } | ||
|
|
||
| if (containerState != HddsProtos.LifeCycleState.DELETING) { | ||
| return false; | ||
| } | ||
|
|
||
| if (request.getContainerReplicas().size() == 0) { | ||
| replicationManager.updateContainerState( | ||
| cID, HddsProtos.LifeCycleEvent.CLEANUP); | ||
| return true; | ||
| } | ||
|
|
||
| Set<DatanodeDetails> pendingDelete = request.getPendingOps().stream() | ||
| .filter(o -> o.getOpType() == ContainerReplicaOp.PendingOpType.DELETE) | ||
| .map(o -> o.getTarget()).collect(Collectors.toSet()); | ||
| //resend deleteCommand if needed | ||
| request.getContainerReplicas().stream() | ||
| .filter(r -> !pendingDelete.contains(r.getDatanodeDetails())) | ||
| .forEach(rp -> { | ||
| try { | ||
| replicationManager.sendDeleteCommand( | ||
| containerInfo, rp.getReplicaIndex(), rp.getDatanodeDetails()); | ||
| } catch (NotLeaderException e) { | ||
| LOG.warn("Failed to delete empty replica with index {} for " + | ||
| "container {} on datanode {}", rp.getReplicaIndex(), | ||
| cID, rp.getDatanodeDetails().getUuidString(), e); | ||
| } | ||
| }); | ||
| return true; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.