Skip to content

Conversation

@duongkame
Copy link
Contributor

@duongkame duongkame commented Sep 26, 2022

What changes were proposed in this pull request?

Server-side implementation of GetKeyInfo API, which implies 2 primary purposes:

  1. It leverages the container location cache to avoid calling SCM to get block location information.
  2. It allows S3G to call without a volume name, which the API can assume. S3G can call GetKeyInfo with assumeS3Context and OM will resolve the s3 volume context (volume name and s3 auth) and include it in the API response. This saves S3G another call to get S3VolumeContext before reading a key.

https://issues.apache.org/jira/browse/HDDS-7230

This PR only includes server-side implementation. Full client-side integration and tests will be done by HDDS-7231.

How was this patch tested?

Unit tests and standard CI: https://github.com/duongkame/ozone/actions/runs/3131964309

@duongkame duongkame marked this pull request as ready for review September 26, 2022 23:32
@duongkame duongkame changed the title HDDS-7230 HDDS-7230. Implement GetKeyInfo API Sep 26, 2022
@duongkame
Copy link
Contributor Author

cc. @kerneltime

@duongkame duongkame force-pushed the HDDS-7230 branch 2 times, most recently from c68446f to 59cef38 Compare October 3, 2022 19:16
@duongkame
Copy link
Contributor Author

@adoroszlai It would be great if you can have a look.

@arp7 arp7 requested review from adoroszlai and kerneltime October 4, 2022 18:08
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @duongkame for the patch, looks mostly good to me.

@kerneltime
Copy link
Contributor

I can merge this in once conflicts are resolved.

@duongkame
Copy link
Contributor Author

I can merge this in once conflicts are resolved.

Thanks for the review @kerneltime, @adoroszlai .

I've just resolved the conflicts. Let's see if there's any problem with CI workflow.

@adoroszlai adoroszlai merged commit 834ef98 into apache:master Oct 11, 2022
@adoroszlai
Copy link
Contributor

Thanks @duongkame for the patch, @kerneltime for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants