-
Notifications
You must be signed in to change notification settings - Fork 590
HDDS-7230. Implement GetKeyInfo API #3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc. @kerneltime |
c68446f to
59cef38
Compare
|
@adoroszlai It would be great if you can have a look. |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @duongkame for the patch, looks mostly good to me.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/CheckedRunnable.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyArgs.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
Outdated
Show resolved
Hide resolved
|
I can merge this in once conflicts are resolved. |
Thanks for the review @kerneltime, @adoroszlai . I've just resolved the conflicts. Let's see if there's any problem with CI workflow. |
|
Thanks @duongkame for the patch, @kerneltime for the review. |
What changes were proposed in this pull request?
Server-side implementation of GetKeyInfo API, which implies 2 primary purposes:
https://issues.apache.org/jira/browse/HDDS-7230
This PR only includes server-side implementation. Full client-side integration and tests will be done by HDDS-7231.
How was this patch tested?
Unit tests and standard CI: https://github.com/duongkame/ozone/actions/runs/3131964309