HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl #3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myskov
changed the title
myskov
force-pushed
the
HDDS-7211_remove_dead_code
branch
2 times, most recently
from
6a51441 to
f162f47
Compare
kerneltime
approved these changes
Sep 19, 2022
Contributor
Contributor
|
I think there needs to be a couple of more reviewers to approve this PR, there is a lot of code that is being deleted (which is good) but we need to be sure that it won't be missed. |
aswinshakil
reviewed
Sep 27, 2022
myskov
force-pushed
the
HDDS-7211_remove_dead_code
branch
4 times, most recently
from
7cbfcfb to
615d168
Compare
myskov
force-pushed
the
HDDS-7211_remove_dead_code
branch
from
615d168 to
f176017
Compare
Contributor
Author
|
@aswinshakil I resolved all conflicts. |
Contributor
Author
|
since @aswinshakil hasn't been active for the last week, could you take a look at the PR please @kerneltime @adoroszlai ? |
adoroszlai
requested review from
adoroszlai and
aswinshakil
and removed request for
aswinshakil
adoroszlai
approved these changes
Oct 6, 2022
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @myskov for the cleanup, LGTM. We can wait for @aswinshakil to take another look before merging this.
aswinshakil
approved these changes
Oct 6, 2022
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for the cleanup @myskov. Approved it. For future reference, Please avoid force pushing as it makes it harder to review incremental changes.
Contributor
|
Thanks @myskov for the patch, @aswinshakil, @kerneltime for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes dead code from omKeyManagerImpl class. The most significant part of the removed code is helper methods of listStatusFSO(), which is unreachable and has been removed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7211
How was this patch tested?
Existing unit and integration tests