HDDS-6440. Handle custom metadata (x-amz-meta) during put-object through S3 API. #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt/OzoneKey.java Co-authored-by: Doroszlai, Attila <[email protected]>
…e into HDDS-6440-master
Contributor
Author
|
cc. kerneltime, adoroszlai |
added 6 commits
August 29, 2022 14:53
kerneltime
reviewed
Aug 31, 2022
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java
Outdated
Show resolved
Hide resolved
kerneltime
reviewed
Aug 31, 2022
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
Show resolved
Hide resolved
kerneltime
reviewed
Aug 31, 2022
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKey.java
Outdated
Show resolved
Hide resolved
added 7 commits
August 31, 2022 11:36
…s key filtering logic;create s3 request metadata size limit constant
kerneltime
reviewed
Sep 1, 2022
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
Outdated
Show resolved
Hide resolved
kerneltime
reviewed
Sep 1, 2022
added 14 commits
September 1, 2022 13:17
…nd gdpr enabled tag
Contributor
Author
kerneltime
reviewed
Sep 21, 2022
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java
Show resolved
Hide resolved
neils-dev
reviewed
Sep 22, 2022
| this.replicationConfig = ReplicationConfig.fromTypeAndFactor(type, | ||
| ReplicationFactor.valueOf(replicationFactor)); | ||
| this(volumeName, bucketName, keyName, size, creationTime, modificationTime, | ||
| ReplicationConfig.fromTypeAndFactor(type, |
Contributor
There was a problem hiding this comment.
Setting the instance this(creationTime, modificationTime ) can remain initialized with Instant.ofEpochMilli(creationTime) and Instant.ofEpochMilli(modificationTime) respectively.
Contributor
There was a problem hiding this comment.
@neils-dev can you please explain, I am not sure I understood your comment.
Contributor
There was a problem hiding this comment.
Sure @kerneltime, the intialization for the creationTime, modification can retain its previous initialization prior to the change:
previous:
this.creationTime = Instant.ofEpochMilli(creationTime);
this.modificationTime = Instant.ofEpochMilli(modificationTime);
now:
line 73,
this(volumeName, bucketName, keyName, size, Instant.ofEpochMilli(creationTime), Instant.ofEpochMilli(modificationTime), ...)
Contributor
There was a problem hiding this comment.
The constructor called internally does the same, right?
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneKeyDetails.java
Outdated
Show resolved
Hide resolved
kerneltime
approved these changes
Sep 27, 2022
kerneltime
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Handle user defined metadata supplied through the s3 interface.
Reference - https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingObjects.html
(This PR is a fork from #3200, with updates from latest master branch and resolve conflicts if there is any.)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6440
How was this patch tested?
Manually tested put, head and copy object.
Added acceptance tests.