Skip to content

HDDS-6942. Ozone Buckets/Objects created via S3 should not allow group access #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 5 commits into from
Jul 2, 2022
Merged

HDDS-6942. Ozone Buckets/Objects created via S3 should not allow group access #3553

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1603472
HDDS-6942. Fix default group permissions for S3 API
kerneltime Jun 27, 2022
82751de
Move S3 configuration setup to OzoneConfigurationHolder
kerneltime Jun 28, 2022
ba640bd
Add smoke test
kerneltime Jun 29, 2022
1a2e7dc
Try config fix against CI
kerneltime Jun 30, 2022
dc04f3d
Merge remote-tracking branch 'origin/master' into HDDS-6942
adoroszlai Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.util.Map;
import java.util.function.Function;

import org.apache.hadoop.hdds.conf.OzoneConfiguration;
import org.apache.hadoop.ozone.audit.AuditAction;
import org.apache.hadoop.ozone.audit.AuditEventStatus;
import org.apache.hadoop.ozone.audit.AuditLogger;
Expand Down Expand Up @@ -63,6 +64,8 @@ public abstract class EndpointBase implements Auditor {
private S3Auth s3Auth;
@Context
private ContainerRequestContext context;
@Inject
private OzoneConfiguration ozoneConfiguration;

private static final Logger LOG =
LoggerFactory.getLogger(EndpointBase.class);
Expand Down Expand Up @@ -98,6 +101,7 @@ protected OzoneBucket getBucket(OzoneVolume volume, String bucketName)
@PostConstruct
public void initialization() {
LOG.debug("S3 access id: {}", s3Auth.getAccessID());
ozoneConfiguration.setIfUnset("ozone.om.group.rights", "NONE");
getClient().getObjectStore()
.getClientProxy()
.setThreadLocalS3Auth(s3Auth);
Expand Down