HDDS-2728. Remove methods of internal representation from DatanodeAdminMontor interface #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inMontor interface
Member
Author
|
@sodonnel please review. |
Contributor
|
This change LGTM and is what we discussed previously. I assume no logic has changed in DatanodeAdminMonitorImpl aside from the constructor, dropped the getters and removing the unused field? As the file was renamed the diff just shows it as all new code. |
sodonnel
approved these changes
Dec 13, 2019
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
This change LGTM and is what we discussed previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatanodeAdminMonitorInterfacehas some settesr and getters but they are not part of the contract they are used by the implementation. An other implementation of the interface may require different setters. Therefore the interface should contain only the required fields.DatanodeAdminMonitorInterfacecan be renamed toDatanodeAdminMonitorto follow the naming convention in the code (*Impl)PipelineManageris unused field can be removed fromDatanodeAdminMonitorImplWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2728
How was this patch tested?
With the existing Unit tests.