-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-6863. Add Group-Id & Ratis-Roles Information for OM UI. #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Group-Id & Ratis-Ring information for OM UI.
|
@siddhantsangwan @sadanand48 @jojochuang @adoroszlai can you please review this patch !! |
|
@ArafatKhan2198 I think it is good practice to ensure CI run in one's own fork succeeds, before opening a PR. |
Thanks I was not aware of that !! |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-overview.html
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
sadanand48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArafatKhan2198 for addressing the comments. Overall changes look good, dropped some minor comments inline.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-overview.html
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMXBean.java
Show resolved
Hide resolved
sadanand48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArafatKhan2198 for addressing comments, +1 LGTM
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArafatKhan2198 for the patch. Mostly looks good, but I think there are some edge cases, and some place for improvement.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMXBean.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay after Attila's comments are addressed.
|
For future reference, it was be nice to show current term and how long has pasted since the last election. (Useful to know if there was any recent election and whether or not the OMs were unstable) |
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js
Outdated
Show resolved
Hide resolved
|
Thanks @ArafatKhan2198 for updating the patch. The order of nodes is still "random", the rest looks good. |
|
@adoroszlai the OM's are now printed in order |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArafatKhan2198 for updating the patch with sorting.
|
Note: Although we used to recommend pushing a new commit to re-trigger the tests, Github now allows committers to re-run only the failed jobs. This also prevents the case where previously passed checks fail in a new run. |
|
Thanks @ArafatKhan2198 for the patch, @jojochuang, @sadanand48 for the review. |
What changes were proposed in this pull request?
Add Group-Id, Current-Node Role, Election Count, Leader Election Elapsed time & the Ratis-Ring information for OM UI.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6863
How was this patch tested?
Tested on docker OM ha env

For a single node cluster it will print STANDALONE
