Skip to content

HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
umamaheswararao merged 1 commit into from
Jun 2, 2022
Merged

HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed #3476

umamaheswararao merged 1 commit into from
Jun 2, 2022

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jun 2, 2022

What changes were proposed in this pull request?

Fix intermittent failure in TestOzoneECClient#testExcludeOnDNMixed.

https://github.com/apache/ozone/runs/6701276416?check_suite_focus=true

What is the link to the Apache JIRA

HDDS-6823

How was this patch tested?

Tested manually by repeating the test 100x in for loop.
And also tested with all other tests in TestOzoneECClient.

@kaijchen
Copy link
Member Author

kaijchen commented Jun 2, 2022

@umamaheswararao previously, running this test alone with 100x is fine.
But it fails when running with other tests in TestOzoneECClient.

I didn't find any issues in shared contexts with other tests,
but imitating testNodeFailuresWhileWriting seems fixes this problem.
I'm not exacly sure why.

@kaijchen kaijchen mentioned this pull request Jun 2, 2022
Merged
@umamaheswararao
Copy link
Contributor

umamaheswararao commented Jun 2, 2022

LGTM, let's see if this fixed other PR test failures.
I can only see pre allocated blocks vs lazily allocated. I think this will do 2 blocks preallocated compared to previous change.
If preallocated 10 nodes will be used, otherwise it may reuse few nodes from previous. Anyway for this tests, preallocating is ok to have better predicted assertions. It would be good to document about this fact if that's true. ANyway for unblocking others I am going ahead to commit this test changes. Thanks a lot @kaijchen for quick investigation.

@umamaheswararao umamaheswararao merged commit b80d354 into apache:master Jun 2, 2022
@rakeshadr rakeshadr mentioned this pull request Jun 3, 2022
Merged
@kaijchen
Copy link
Member Author

kaijchen commented Jun 3, 2022

Thanks @umamaheswararao for the review.

@kaijchen kaijchen deleted the HDDS-6823 branch June 3, 2022 03:15
errose28 added a commit to errose28/ozone that referenced this pull request Jun 7, 2022
@errose28
Merge branch 'master' into HDDS-6760
049d7bc 
* master: (87 commits)
  HDDS-6686. Do Leadship check before SASL token verification. (apache#3382)
  HDDS-4364: [FSO]List FileStatus : startKey can be a non-existed path (apache#3481)
  HDDS-6091. Add file checksum to OmKeyInfo (apache#3201)
  HDDS-6706. Exposing Volume Information Metrics to the DataNode UI (apache#3478)
  HDDS-6759: Add listblock API in MockDatanodeStorage (apache#3452)
  HDDS-5821 Container cache management for closing RockDB  (apache#3426)
  HDDS-6683. Refactor OM server bucket layout configuration usage (apache#3477)
  HDDS-6824. Revert changes made in proto.lock by HDDS-6768. (apache#3480)
  HDDS-6811. Bucket create message with layout type (apache#3479)
  HDDS-6810. Add a optional flag to trigger listStatus as part of listKeys for FSO buckets. (apache#3461)
  HDDS-6828. Revert RockDB version pending leak fixes (apache#3475)
  HDDS-6764: EC: DN ability to create RECOVERING containers for EC reconstruction. (apache#3458)
  HDDS-6795: EC: PipelineStateMap#addPipeline should not have precondition checks post db updates (apache#3453)
  HDDS-6823. Intermittent failure in TestOzoneECClient#testExcludeOnDNMixed (apache#3476)
  HDDS-6820. Bucket Layout Post-Finalization Validators for ACL Requests. (apache#3472)
  HDDS-6819. Add LEGACY to AllowedBucketLayouts in CreateBucketHandler (apache#3473)
  HDDS-4859. [FSO]ListKeys: seek all the files/dirs from startKey to keyPrefix (apache#3466)
  HDDS-6705 Add metrics for volume statistics including disk capacity, usage, Reserved (apache#3430)
  HDDS-6474. Add test to cover the FSO bucket list status with beyond batch boundary and cache. (apache#3379). Contributed by aswinshakil
  HDDS-6280. Support Container Balancer HA (apache#3423)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umamaheswararao umamaheswararao umamaheswararao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaijchen @umamaheswararao