-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-6681. Post-Finalize behaviour for Bucket Layout feature. #3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @JyotinderSingh for working on this. Opening PR as draft lets Github skip CI on WIP code to reduce resource usage. If you still would like CI feedback for your work, please enable the |
Thank you for the suggestion @adoroszlai! I will enable the workflow in my branch. |
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @JyotinderSingh. I think there are more requests we need to cover to fully block older clients from new bucket layouts. Things like get bucket, read/write/delete for files, directories, and keys, list and rename operations, etc.
...e-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java
Outdated
Show resolved
Hide resolved
|
Are we planning on introducing the |
Yes @errose28 I had prepared an initial patch to showcase the approach I would be following while implementing the post finalization behaviour. |
Thanks @errose28 for pointing out this. @JyotinderSingh has created a separate sub-task HDDS-6683 to discuss and implement this behavior. Thanks @JyotinderSingh for splitting the task and IMHO that will help to make more specific discussions/tracking. |
avijayanhwx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @JyotinderSingh. Approach looks good to me. Had a question on the create bucket validation?
...e-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
Outdated
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyPurgeRequest.java
Outdated
Show resolved
Hide resolved
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
...e-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java
Outdated
Show resolved
Hide resolved
...one-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/BucketLayout.java
Outdated
Show resolved
Hide resolved
|
@JyotinderSingh Thanks for working on this . The Problem with testTrash is because TrashOzoneFilesystem.java uses an old client version in its client requests. Please set the version to ClientVersion.CURRENT in the requests. Attaching patch here for a quick apply. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Show resolved
Hide resolved
...-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/RequestValidations.java
Show resolved
Hide resolved
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the addition and debugging @JyotinderSingh.
rakeshadr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM. Thanks @JyotinderSingh for the good work!
|
Thank you @rakeshadr @errose28 @avijayanhwx @sadanand48 @adoroszlai for the helpful discussion and reviews. |
What changes were proposed in this pull request?
This Jira implements the post-finalization behavior of the Bucket Layout feature.
Post Finalization behavior for this feature from a backward compatibility perspective is defined as follows:
Older clients cannot read any data from an FSO/OBS bucket.
Older clients cannot create keys/directories in FSO/OBS buckets.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6681
How was this patch tested?
Existing tests.