Skip to content

Conversation

@JyotinderSingh
Copy link
Contributor

@JyotinderSingh JyotinderSingh commented May 13, 2022

What changes were proposed in this pull request?

This Jira implements the post-finalization behavior of the Bucket Layout feature.

Post Finalization behavior for this feature from a backward compatibility perspective is defined as follows:

Older clients cannot read any data from an FSO/OBS bucket.
Older clients cannot create keys/directories in FSO/OBS buckets.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6681

How was this patch tested?

Existing tests.

@adoroszlai adoroszlai marked this pull request as draft May 13, 2022 08:52
@adoroszlai
Copy link
Contributor

Thanks @JyotinderSingh for working on this. Opening PR as draft lets Github skip CI on WIP code to reduce resource usage. If you still would like CI feedback for your work, please enable the build-branch workflow in your fork.

@JyotinderSingh
Copy link
Contributor Author

Thanks @JyotinderSingh for working on this. Opening PR as draft lets Github skip CI on WIP code to reduce resource usage. If you still would like CI feedback for your work, please enable the build-branch workflow in your fork.

Thank you for the suggestion @adoroszlai! I will enable the workflow in my branch.

Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @JyotinderSingh. I think there are more requests we need to cover to fully block older clients from new bucket layouts. Things like get bucket, read/write/delete for files, directories, and keys, list and rename operations, etc.

@errose28
Copy link
Contributor

Are we planning on introducing the SERVER_DEFAULT layout and its handling for newer clients in this PR or a different one?

@JyotinderSingh
Copy link
Contributor Author

Thanks for working on this @JyotinderSingh. I think there are more requests we need to cover to fully block older clients from new bucket layouts. Things like get bucket, read/write/delete for files, directories, and keys, list and rename operations, etc.

Yes @errose28 I had prepared an initial patch to showcase the approach I would be following while implementing the post finalization behaviour.
I had tried to cover a few different kinds of requests at first so it would be easier to review.

@rakeshadr
Copy link
Contributor

rakeshadr commented May 16, 2022

Are we planning on introducing the SERVER_DEFAULT layout and its handling for newer clients in this PR or a different one?

Thanks @errose28 for pointing out this. @JyotinderSingh has created a separate sub-task HDDS-6683 to discuss and implement this behavior. Thanks @JyotinderSingh for splitting the task and IMHO that will help to make more specific discussions/tracking.

@JyotinderSingh JyotinderSingh marked this pull request as ready for review May 17, 2022 10:19
Copy link
Contributor

@avijayanhwx avijayanhwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @JyotinderSingh. Approach looks good to me. Had a question on the create bucket validation?

@sadanand48
Copy link
Contributor

@JyotinderSingh Thanks for working on this . The Problem with testTrash is because TrashOzoneFilesystem.java uses an old client version in its client requests. Please set the version to ClientVersion.CURRENT in the requests. Attaching patch here for a quick apply.

Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the addition and debugging @JyotinderSingh.

Copy link
Contributor

@rakeshadr rakeshadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM. Thanks @JyotinderSingh for the good work!

@JyotinderSingh
Copy link
Contributor Author

Thank you @rakeshadr @errose28 @avijayanhwx @sadanand48 @adoroszlai for the helpful discussion and reviews.
Merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants