HDDS-6599. Use a single property to define ozone version

[myskov]

What changes were proposed in this pull request?

Setting ozone.version independently makes it hard to automatic version update using 'mvn versions:set' command. This change makes 'project.version' a single source of ozone version. In addition, plugin introduced in HDDS-6304 (which tried to solve the same issue) has been removed.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6599

How was this patch tested?

The following command ended with a success:
mvn versions:set -DnewVersion=1.4.0-SNAPSHOT -DprocessAllModules && mvn clean install

The above command fails without the proposed changed because 'versions:set' is not applied to ozone-annotation-processing module

[smengcl]

lgtm. But just in case I missed anything, it would great if @adoroszlai would take a look as well.

The removed enforce-property was added 2 months back in HDDS-6304. It doesn't seem necessary anymore once we start using project version here:

ozone/pom.xml

Line 21 in 55d5ecb

<version>1.3.0-SNAPSHOT</version>

[adoroszlai]

The current model (ozone.version independent of project.version) was introduced when Ozone was part of the Hadoop codebase, as a way to allow using different version number for these two. Currently it is not necessary and could be removed. But it provides the flexibility to let an existing or new submodule use different version later.

command fails without the proposed changed because 'versions:set' is not applied to ozone-annotation-processing module

Thanks for pointing that out. I think we should fix this problem by making that module part of the regular Ozone project hierarchy.

[myskov]

I think we should fix this problem by making that module part of the regular Ozone project hierarchy.

It wouldn't fix the problem because there is still a requirement (introduced by #3075) to make project.version equal to ozone.version which cannot be achieved by mvn versions:set

[myskov]

@adoroszlai as an alternative, the following changes can be done instead of affecting ozone.version:

• remove maven-enforcer plugin (the same change as in this PR)
• change the following dependency to use project.version instead of ozone.version:

   <dependency>
      <groupId>org.apache.ozone</groupId>
      <artifactId>ozone-annotation-processing</artifactId>
      <version>${ozone.version}</version>
    </dependency>

[adoroszlai]

there is still a requirement (introduced by #3075) to make project.version equal to ozone.version which cannot be achieved by mvn versions:set

#3075 only added the enforcer check to avoid version mismatch. ozone.version always had to be updated manually during the release process.

[adoroszlai]

@myskov I think we should have a discussion about this (keep or drop the ozone.version property) in the dev mailing list. Can you please start one?

[adoroszlai]

/pending discussion on dev list

[github-actions]

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

discussion on dev list

[github-actions]

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."