HDDS-6476. Support FSO in OMOpenKeysDeleteRequest and Response #3233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshadr
reviewed
Apr 6, 2022
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
kaijchen
changed the title
rakeshadr
reviewed
Apr 6, 2022
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
Contributor
Member
Author
|
Thanks @rakeshadr for the review. I have rebased it to master. I'm thinking of handling legacy keys and FSO keys in different requests. EDIT: Yes we can improve it since HDDS-6523 has been merged. |
kaijchen
force-pushed
the
HDDS-6476
branch
2 times, most recently
from
a3501e4 to
3f18975
Compare
Member
Author
|
Since HDDS-6556 is still under discussion, let's keep pushing open key cleanup service forward. |
Contributor
|
LGTM |
errose28
reviewed
May 6, 2022
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
...anager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMOpenKeysDeleteRequest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
I have updated this PR since HDDS-6491 has been merged, please take another look @errose28 @rakeshadr @captainzmc. |
captainzmc
reviewed
May 24, 2022
...ne-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMOpenKeysDeleteRequest.java
Show resolved
Hide resolved
Member
|
Thanks @kaijchen for the patch and thanks @errose28 @rakeshadr @kerneltime for the review. Let's merge this and keep pushing open key cleanup service forward. |
Member
Author
|
Thanks @captainzmc @errose28 @rakeshadr for the review. |
kaijchen
added a commit
to kaijchen/ozone
that referenced
this pull request
Jun 27, 2022
…e#3233) * Support FSO keys in OpenKeysDeleteRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support FSO bucket in OMOpenKeysDeleteRequest and Response.
OpenKeyBucketproto changed in HDDS-6491.OMOpenKeysDeleteRequest/Responseto support deleting keys in OpenFileTable.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6476
How was this patch tested?
Unit tests.