Skip to content

HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
captainzmc merged 1 commit into from
Feb 15, 2022
Merged

HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE #3060

captainzmc merged 1 commit into from
Feb 15, 2022

Conversation

@guohao-rosicky
Copy link
Contributor

@guohao-rosicky guohao-rosicky commented Feb 9, 2022

What changes were proposed in this pull request?

Fix BlockDataStreamOutput#doFlushIfNeeded NPE

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6282

ayushtkn
ayushtkn requested changes Feb 9, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case

@guohao-rosicky
Copy link
Contributor Author

guohao-rosicky commented Feb 9, 2022

Add a test case

This is a fix for a bug that reported errors in JIRA. Use the existing test.

@captainzmc
Copy link
Member

captainzmc commented Feb 10, 2022

Add a test case

Thanks @ayushtkn for the review. this bug was found in our patch that s3gateway support streaming write(HDDS-5869).
After we enabled s3 streaming, we found that many CI test cases were reported to NPE. So, there are enough test cases to support this PR.
After this PR merge, we will continue the development of #2858.

@captainzmc
Copy link
Member

captainzmc commented Feb 10, 2022

Hi @guohao-rosicky HDDS-4454 was synchronous with master branch. Can you rebase this patch？ I think we can merge this bug fix first and continue #2858.

@captainzmc captainzmc self-requested a review February 10, 2022 01:27
@captainzmc captainzmc requested a review from ayushtkn February 14, 2022 02:17
captainzmc
captainzmc approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@captainzmc captainzmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 The change looks good.

@captainzmc
Copy link
Member

captainzmc commented Feb 15, 2022

Failed CI has nothing to do with this PR. Let's merge this patch first and then continue HDDS-5869. Thanks @guohao-rosicky fix this and thanks @ayushtkn for the review.

@captainzmc captainzmc closed this Feb 15, 2022
@captainzmc captainzmc reopened this Feb 15, 2022
@captainzmc captainzmc merged this pull request into apache:HDDS-4454 Feb 15, 2022
szetszwo pushed a commit that referenced this pull request Feb 16, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
aac9215
szetszwo pushed a commit that referenced this pull request Mar 15, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
45d8f51
szetszwo pushed a commit that referenced this pull request Mar 24, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
1bb85c7
szetszwo pushed a commit to szetszwo/ozone that referenced this pull request May 6, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (apache#3060)
c131281
szetszwo pushed a commit that referenced this pull request May 13, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
07d8876
szetszwo pushed a commit that referenced this pull request May 24, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
b09515f
szetszwo pushed a commit that referenced this pull request Jun 9, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
1ae8d86
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 4, 2022
@guohao-rosicky @captainzmc
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (apache#3060)
8f8f166
szetszwo pushed a commit that referenced this pull request Oct 25, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
cca5e3b 
(cherry picked from commit 8f8f166)
(cherry picked from commit 9d24f5870443ad3a9f8b6a508bcc1426e3c8bc4f)
szetszwo pushed a commit that referenced this pull request Nov 7, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
fce0dfa 
(cherry picked from commit 8f8f166)
(cherry picked from commit 9d24f5870443ad3a9f8b6a508bcc1426e3c8bc4f)
(cherry picked from commit cca5e3b)
szetszwo pushed a commit that referenced this pull request Dec 1, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
9330807 
(cherry picked from commit fce0dfa)
szetszwo pushed a commit that referenced this pull request Dec 16, 2022
@guohao-rosicky @szetszwo
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (#3060)
92054a4 
(cherry picked from commit fce0dfa)
nishitpatira pushed a commit to nishitpatira/ozone that referenced this pull request Dec 16, 2022
@guohao-rosicky
HDDS-6282. Fix BlockDataStreamOutput#doFlushIfNeeded NPE (apache#3060)
187cde7 
(cherry picked from commit fce0dfa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainzmc captainzmc captainzmc approved these changes

@ayushtkn ayushtkn Awaiting requested review from ayushtkn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guohao-rosicky @captainzmc @ayushtkn