Skip to content

HDDS-2656. Prefer execute() over submit() if the returned Future is ignored #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuengineer merged 2 commits into from
Dec 4, 2019
Merged

HDDS-2656. Prefer execute() over submit() if the returned Future is ignored #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c1c69
HDDS-2656. Prefer execute() over submit() if the returned Future is i…
adoroszlai Dec 2, 2019
d3e23e3
Merge remote-tracking branch 'origin/master' into HDDS-2656
adoroszlai Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/cache/TableCacheImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public void put(CACHEKEY cacheKey, CACHEVALUE value) {
}

public void cleanup(List<Long> epochs) {
executorService.submit(() -> evictCache(epochs));
executorService.execute(() -> evictCache(epochs));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...ce/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public ReplicationSupervisor(
*/
public void addTask(ReplicationTask task) {
if (containersInFlight.add(task.getContainerId())) {
executor.submit(new TaskRunner(task));
executor.execute(new TaskRunner(task));
}
}

Expand Down
4 changes: 2 additions & 2 deletions ...vice/src/test/java/org/apache/hadoop/ozone/container/keyvalue/helpers/TestChunkUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void concurrentReadOfSameFile() throws Exception {
AtomicBoolean failed = new AtomicBoolean();
for (int i = 0; i < threads; i++) {
final int threadNumber = i;
executor.submit(() -> {
executor.execute(() -> {
try {
ByteBuffer readBuffer = ChunkUtils.readData(file, chunkInfo, stats);
LOG.info("Read data ({}): {}", threadNumber,
Expand Down Expand Up @@ -120,7 +120,7 @@ public void concurrentProcessing() throws Exception {
for (int i = 0; i < threads; i++) {
Path path = Files.createTempFile(PREFIX, String.valueOf(i));
paths.add(path);
executor.submit(() -> {
executor.execute(() -> {
ChunkUtils.processFileExclusively(path, () -> {
try {
Thread.sleep(perThreadWait);
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ public Void call() throws Exception {
LOG.info("Buffer size: {} bytes", bufferSize);
LOG.info("validateWrites : {}", validateWrites);
for (int i = 0; i < numOfThreads; i++) {
executor.submit(new ObjectCreator());
executor.execute(new ObjectCreator());
}

Thread validator = null;
Expand Down