Skip to content

HDDS-6203. CleanUp incomplete gz files during Container move #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenSammi merged 2 commits into from
Jan 23, 2022
Merged

HDDS-6203. CleanUp incomplete gz files during Container move #3000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b06e3
HDDS-6203. CleanUp gz files failed to be fully written during Contain…
Xushaohong Jan 19, 2022
94004ff
improve part of logic
Xushaohong Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ...ce/src/main/java/org/apache/hadoop/ozone/container/replication/GrpcReplicationClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,16 @@ public void onNext(CopyContainerResponseProto chunk) {
try {
chunk.getData().writeTo(stream);
} catch (IOException e) {
response.completeExceptionally(e);
LOG.error("Failed to write the stream buffer to {} for container {}",
outputPath, containerId, e);
try {
stream.close();
} catch (IOException ex) {
LOG.error("Failed to close OutputStream {}", outputPath, e);
} finally {
deleteOutputOnFailure();
response.completeExceptionally(e);
}
}
}

Expand All @@ -176,6 +185,7 @@ public void onError(Throwable throwable) {
} catch (IOException e) {
LOG.error("Failed to close {} for container {}",
outputPath, containerId, e);
deleteOutputOnFailure();
response.completeExceptionally(e);
}
}
Expand All @@ -189,9 +199,9 @@ public void onCompleted() {
} catch (IOException e) {
LOG.error("Downloaded container {} OK, but failed to close {}",
containerId, outputPath, e);
deleteOutputOnFailure();
response.completeExceptionally(e);
}

}

private void deleteOutputOnFailure() {
Expand All @@ -204,5 +214,4 @@ private void deleteOutputOnFailure() {
}
}
}

}