HDDS-5385. [FSO] Remove ozone.om.metadata.layout config in OM #2887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JyotinderSingh
changed the title
rakeshadr
reviewed
Dec 6, 2021
Contributor
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
Thanks @JyotinderSingh for the good work. Added few comments, please go through it.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/NSSummaryAdmin.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/NSSummaryCLIUtils.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/NSSummaryAdmin.java
Outdated
Show resolved
Hide resolved
...ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the reviews @rakeshadr. I have addressed your comments in my latest commit. |
rakeshadr
approved these changes
Dec 8, 2021
Contributor
rakeshadr
left a comment
rakeshadr
left a comment
There was a problem hiding this comment.
+1 LGTM, thanks @JyotinderSingh
Pending build CI
JyotinderSingh
force-pushed
the
HDDS-5385
branch
from
c4ac029 to
135eaeb
Compare
Contributor
|
Thanks @JyotinderSingh for rebased the patch. We got a clean build and I'm merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This task is to remove the metadata layout config as bucket type will be an argument. Also, will define
ozone.bucket.type.defaultto handle a case where the user is not passing any args.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5385
How was this patch tested?
related integration tests