HDDS-5943. Shutdown ResultHandlerExecutorService for StorageVolumeChecker. #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Nov 8, 2021
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks a lot @guihecheng for the fix. CI passes either way, but I have also encountered the OOM locally, so could verify this.
Contributor
Author
|
@adoroszlai thanks, the github CI machine may have a lot of resources enough to bear this leak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shutdown ResultHandlerExecutorService for StorageVolumeChecker.
This fixes an OOM for unit test TestStorageVolumeChecker.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5943
How was this patch tested?
existing ut.