HDDS-2640 Add leaderID information in pipeline list subcommand

[nilotpalnandi]

What changes were proposed in this pull request?

scmcli pipeline list command does not display the leaderID information for each pipeline.
This change will include the leaderID information along with other details.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2640

How was this patch tested?

Applied the patch and rebuilt ozone and then tested it by creating docker cluster using docker-compose

[lokeshj1703]

@nilotpalnandi Thanks for working on this! The changes look good to me. Pending jenkins.

[lokeshj1703]

The test failure does not seem related.

[lokeshj1703]

@nilotpalnandi Thanks for the contribution! I have committed the PR to master branch.

[elek]

The test failure does not seem related.

Please don't commit patches with failing unit test, even if they are unrelated. The acceptance tests are not executed for this patch because the unit tests are failed.

If you think it's not related, please create a jira, copy the failure and the logs and @Ignore the test, but get a green build.

[lokeshj1703]

@elek Sorry! I have created https://issues.apache.org/jira/browse/HDDS-2643 which tracks the failure. The test failure is intermittent.

[elek]

No problem, (and don't need to revert). I just realized how small this patch after I wrote the comment, so I understand that it's very low chance to introduce any problem (unless one acceptance test checks the output of the pipeline command).

It was more like a FYI:

Master become unstable again and having reports for all the checks would help to understand the root of the problems.

The problem is that we have a strong dependency between acceptance and unit and if unit is failed (even if because and intermittent error) the acceptance tests are not executed.

We need to remove this dependency OR always fix (or rerun) the unit test.

[lokeshj1703]

@elek Yeah I agree. I think removing the dependency between acceptance test and unit would be great because there are a lot of tests which fail intermittently.
The post commit build failed with failure in TestTableCacheImpl.

[adoroszlai]

We need to remove this dependency OR always fix (or rerun) the unit test.

+1 for removing the dependency: it would also let acceptance tests start ~20 minutes earlier, reducing overall feedback time by 25% (80 -> 60 minutes).