Skip to content

HDDS-5529. For any IOexception from @Replicated method we should throw it #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smengcl merged 4 commits into from
Feb 2, 2022
Merged

HDDS-5529. For any IOexception from @Replicated method we should throw it #2788

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
316df48
HDDS-5529. For any exception from @Replicated method we should throw …
Nov 8, 2021
22daf1c
ignore pipelineNotFound exception
Dec 13, 2021
bf5d2d3
triger CI
Dec 14, 2021
6ec391a
Update hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/sc…
Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...erver-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,8 @@ public void updatePipelineState(
HddsProtos.PipelineID pipelineIDProto, HddsProtos.PipelineState newState)
throws IOException {
PipelineID pipelineID = PipelineID.getFromProtobuf(pipelineIDProto);
Pipeline.PipelineState oldState = null;
lock.writeLock().lock();
try {
oldState = getPipeline(pipelineID).getPipelineState();
// null check is here to prevent the case where SCM store
// is closed but the staleNode handlers/pipeline creations
// still try to access it.
Expand All @@ -275,9 +273,8 @@ public void updatePipelineState(
LOG.warn("Pipeline {} is not found in the pipeline Map. Pipeline"
+ " may have been deleted already.", pipelineID);
} catch (IOException ex) {
LOG.warn("Pipeline {} state update failed", pipelineID);
// revert back to old state in memory
pipelineStateMap.updatePipelineState(pipelineID, oldState);
LOG.error("Pipeline {} state update failed", pipelineID);
throw ex;
} finally {
lock.writeLock().unlock();
}
Expand Down