-
Notifications
You must be signed in to change notification settings - Fork 592
HDDS-5743.[Ozone-Streaming] Add option to write files via streaming api in ofs and o3fs. #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @sadanand48 thanks for the patch. Can you rebase branch/HDDS-4454 and recommit the code? Now this PR has some conflicts. |
szetszwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadanand48 , thanks a lot for working on this. Just a minor comment about the conf.
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
szetszwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
|
@sadanand48 , TestOzoneConfigurationFields failed. It is related to the new conf. Please take a look. Thanks. |
captainzmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Overall. After the CI problem is resolved, we can merge this.
9e868ce to
db98913
Compare
…pi in ofs and o3fs (cherry picked from commit d0e9c0acebc6b18d7d2d389e0663278d55298722)
db98913 to
80f6d5c
Compare
…pi in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (apache#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (#2770)
…api in ofs and o3fs. (apache#2770)
…api in ofs and o3fs. (apache#2770) (cherry picked from commit d81ca2a)
What changes were proposed in this pull request?
Add option to write files via streaming api in ofs and o3fs
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5743
How was this patch tested?
Existing FS tests. Streaming flag is set to true in branch HDDS-4454.