HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStreamKey method #2760

guohao-rosicky · 2021-10-22T02:32:05Z

https://issues.apache.org/jira/browse/HDDS-5879

OzoneBucket and RpcClient not support multipart upload with Stream.
Add the createMultipartStreamKey method

captainzmc · 2021-10-22T04:40:28Z

Thanks @guohao-rosicky for your contribution. Could you update the URL of jira in comment? Also, the current code check style still has some problems, and it is better to add some UT to test the new interface.

guohao-rosicky · 2021-10-22T10:19:52Z

jira url: https://issues.apache.org/jira/browse/HDDS-5879

guohao-rosicky · 2021-10-22T10:22:58Z

Thanks @captainzmc , has been modified.

bharatviswa504 · 2021-10-22T16:53:07Z

hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java

Can we create a Jira for this TODO

Thanks @bharatviswa504 , new jira url: https://issues.apache.org/jira/browse/HDDS-5892

guohao-rosicky · 2021-10-25T03:45:48Z

Thanks @captainzmc , already added UT.

szetszwo

Thanks for working on this. Just a question inlined.

szetszwo · 2021-10-28T06:57:07Z

hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java

Why we pass replicationConfig but not use openKey.getKeyInfo().getReplicationConfig()?

@szetszwo
I noticed it. Thanks for reminding me. I have revised it.

…mKey method

szetszwo

@guohao-rosicky , thanks for the update.

The new testMultiPartUploadWithStream() failed. Please take a look.

I also have a minor comment inlined.

szetszwo · 2021-11-16T10:14:45Z

hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java

+    if (feInfo != null) {
+      // todo: need to support file encrypt,
+      //  https://issues.apache.org/jira/browse/HDDS-5892
+      return null;


Let's throw a UnsupportedOperationException.

throw new UnsupportedOperationException( "FileEncryptionInfo is not yet supported in createMultipartStreamKey");

…mKey method

szetszwo · 2021-11-17T10:12:41Z

@guohao-rosicky , TestOzoneRpcClientAbstract.testMultiPartUploadWithStream failed again in the last build. Please take a look.

…mKey method

guohao-rosicky · 2021-11-19T01:55:10Z

@guohao-rosicky , TestOzoneRpcClientAbstract.testMultiPartUploadWithStream failed again in the last build. Please take a look.

Thanks @szetszwo , please TBR.

szetszwo

+1 the change looks good.

…mKey method (#2760)

…mKey method (apache#2760)

…mKey method (#2760)

…mKey method (apache#2760)

…mKey method (#2760) (cherry picked from commit be9641f) (cherry picked from commit 9a16e41e1f29373e0e0f2a186237ded0dd0b53b4)

…mKey method (#2760) (cherry picked from commit be9641f) (cherry picked from commit 9a16e41e1f29373e0e0f2a186237ded0dd0b53b4) (cherry picked from commit 8de50af)

…mKey method (#2760) (cherry picked from commit 2054fe4)

…mKey method (apache#2760) (cherry picked from commit 2054fe4)

guohao-rosicky force-pushed the ozone-client-multipart-stream-key branch from f7ea63a to 46f4fa4 Compare October 22, 2021 10:18

bharatviswa504 reviewed Oct 22, 2021

View reviewed changes

captainzmc self-requested a review October 25, 2021 02:50

guohao-rosicky force-pushed the ozone-client-multipart-stream-key branch from 46f4fa4 to dffcd34 Compare October 25, 2021 03:42

guohao-rosicky requested a review from bharatviswa504 October 25, 2021 03:47

captainzmc requested a review from szetszwo October 25, 2021 12:28

szetszwo reviewed Oct 28, 2021

View reviewed changes

szetszwo force-pushed the HDDS-4454 branch from ced177b to 976b141 Compare October 28, 2021 07:17

szetszwo force-pushed the HDDS-4454 branch from 871f2cd to 1d9f870 Compare November 15, 2021 04:46

guohao-rosicky force-pushed the ozone-client-multipart-stream-key branch 2 times, most recently from e10fe82 to b9c5d4c Compare November 16, 2021 05:33

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

c47548a

…mKey method

guohao-rosicky force-pushed the ozone-client-multipart-stream-key branch from b9c5d4c to c47548a Compare November 16, 2021 08:53

szetszwo reviewed Nov 16, 2021

View reviewed changes

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

05b3e8c

…mKey method

guohao-rosicky added 3 commits November 18, 2021 10:34

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

7fe0fa5

…mKey method

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

2be41a3

…mKey method

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

b654cca

…mKey method

szetszwo approved these changes Nov 19, 2021

View reviewed changes

szetszwo merged commit a8a25b8 into apache:HDDS-4454 Nov 19, 2021

szetszwo pushed a commit that referenced this pull request Nov 30, 2021

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

f400954

…mKey method (#2760)

captainzmc pushed a commit that referenced this pull request Dec 20, 2021

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

26877bd

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request Dec 30, 2021

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

bd13493

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request Jan 20, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

b8d31f2

…mKey method (#2760)

captainzmc pushed a commit that referenced this pull request Feb 9, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

27c395a

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request Feb 16, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

a65c5d1

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request Mar 15, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

b6f5244

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request Mar 24, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

a8d7669

…mKey method (#2760)

szetszwo pushed a commit to szetszwo/ozone that referenced this pull request May 6, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

22d0553

…mKey method (apache#2760)

szetszwo pushed a commit that referenced this pull request May 13, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

be48e28

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request May 24, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

d159210

…mKey method (#2760)

szetszwo pushed a commit that referenced this pull request Jun 9, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

085bbf1

…mKey method (#2760)

captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 4, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

be9641f

…mKey method (apache#2760)

szetszwo pushed a commit that referenced this pull request Oct 25, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

8de50af

…mKey method (#2760) (cherry picked from commit be9641f) (cherry picked from commit 9a16e41e1f29373e0e0f2a186237ded0dd0b53b4)

szetszwo pushed a commit that referenced this pull request Dec 1, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

3f1e2a5

…mKey method (#2760) (cherry picked from commit 2054fe4)

szetszwo pushed a commit that referenced this pull request Dec 16, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

237e0af

…mKey method (#2760) (cherry picked from commit 2054fe4)

nishitpatira pushed a commit to nishitpatira/ozone that referenced this pull request Dec 16, 2022

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStrea…

4d56f2c

…mKey method (apache#2760) (cherry picked from commit 2054fe4)

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStreamKey method #2760

HDDS-5879. [Ozone-Streaming] OzoneBucket add the createMultipartStreamKey method #2760

Uh oh!

Conversation

guohao-rosicky commented Oct 22, 2021 • edited by szetszwo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

captainzmc commented Oct 22, 2021

Uh oh!

guohao-rosicky commented Oct 22, 2021

Uh oh!

guohao-rosicky commented Oct 22, 2021

Uh oh!

bharatviswa504 Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

guohao-rosicky Oct 24, 2021

Choose a reason for hiding this comment

Uh oh!

guohao-rosicky commented Oct 25, 2021

Uh oh!

szetszwo left a comment

Choose a reason for hiding this comment

Uh oh!

szetszwo Oct 28, 2021

Choose a reason for hiding this comment

Uh oh!

guohao-rosicky Nov 15, 2021

Choose a reason for hiding this comment

Uh oh!

szetszwo left a comment

Choose a reason for hiding this comment

Uh oh!

szetszwo Nov 16, 2021

Choose a reason for hiding this comment

Uh oh!

szetszwo commented Nov 17, 2021

Uh oh!

guohao-rosicky commented Nov 19, 2021

Uh oh!

szetszwo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guohao-rosicky commented Oct 22, 2021 •

edited by szetszwo

Loading