Skip to content

Conversation

@cxorm
Copy link
Member

@cxorm cxorm commented Nov 25, 2019

What changes were proposed in this pull request?

Re-Interrupt when catching the InterruptedException.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2565

How was this patch tested?

UT Updating to validate the behavior.

@cxorm
Copy link
Member Author

cxorm commented Dec 3, 2019

/retest

@elek
Copy link
Member

elek commented Dec 3, 2019

FYI: /retest is not working (yet) with github actions. Just push an empty commit (git commit --allow-empty -m "...") and push it.

@cxorm
Copy link
Member Author

cxorm commented Dec 4, 2019

Thanks @elek for the information.

@cxorm
Copy link
Member Author

cxorm commented Dec 5, 2019

The acceptance test failure does not seem to be related to this patch.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks the contrinution @cxorm

The acceptance test is fixed in a newer commit (6c1a9ff) (Checked the error and this is the same).

Will merge it soon.

@elek elek closed this in 4f1869c Dec 5, 2019
@cxorm
Copy link
Member Author

cxorm commented Dec 5, 2019

Thanks @elek for the review and commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants