Skip to content

HDDS-5742. [Ozone-Streaming] Avoid unnecessary Bytebuffer conversions #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szetszwo merged 1 commit into from
Sep 23, 2021
Merged

HDDS-5742. [Ozone-Streaming] Avoid unnecessary Bytebuffer conversions #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...p-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockDataStreamOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,7 @@ private void writeChunkToContainer(ByteBuffer buf)
throws IOException {
final int effectiveChunkSize = buf.remaining();
final long offset = chunkOffset.getAndAdd(effectiveChunkSize);
ChecksumData checksumData =
checksum.computeChecksum(buf.asReadOnlyBuffer());
ChecksumData checksumData = checksum.computeChecksum(buf);
ChunkInfo chunkInfo = ChunkInfo.newBuilder()
.setChunkName(blockID.get().getLocalID() + "_chunk_" + ++chunkIndex)
.setOffset(offset)
Expand Down
5 changes: 5 additions & 0 deletions hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/Checksum.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ public ChecksumData computeChecksum(byte[] data)
*/
public ChecksumData computeChecksum(ByteBuffer data)
throws OzoneChecksumException {
// If type is set to NONE, we do not need to compute the checksums. We also
// need to avoid unnecessary conversions.
if (checksumType == ChecksumType.NONE) {
return new ChecksumData(checksumType, bytesPerChecksum);
}
if (!data.isReadOnly()) {
data = data.asReadOnlyBuffer();
}
Expand Down