HDDS-2627. Skip sonar check in forks #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
pushed a commit
that referenced
this pull request
Nov 25, 2019
Contributor
Author
|
Thanks @elek for pushing it to https://github.com/apache/hadoop-ozone/runs/319300695 |
Contributor
Author
|
@elek @vivekratnavel please review |
Contributor
Author
|
Thanks @vivekratnavel and @arp7 for reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-2587 added Sonar check in post-commit workflow, publishing results to SonarCloud. It does not work in forks, as it requires SonarCloud token. This causes unit check to fail completely. Example: https://github.com/bharatviswa504/hadoop-ozone/runs/316829850
This PR proposes to skip the check for forks. (Ideally it would be skipped if
SONARCLOUD_TOKENis not set, but I could not add a condition based on that.)https://issues.apache.org/jira/browse/HDDS-2627
How was this patch tested?
Pushed to own fork: unit check passed, sonar step skipped.
It would be great if someone with write access to
apache/hadoop-ozonecould push the same to a "feature" branch and verify that Sonar check is executed as expected.