Skip to content

Conversation

@iamabug
Copy link
Contributor

@iamabug iamabug commented Aug 26, 2021

What changes were proposed in this pull request?

doc translation

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5564

How was this patch tested?

hugo server under docs diectory.

image

@iamabug iamabug added the documentation Improvements or additions to documentation label Aug 26, 2021
@iamabug
Copy link
Contributor Author

iamabug commented Aug 26, 2021

cc @sky76093016

menu:
main:
parent: 特性
summary: 支持Supports atomic rename and delete operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

支持 and support appear repeatedly, it would be better to change to the above.

Suggested change
summary: 支持Supports atomic rename and delete operation.
summary: 支持 atomic 重命名和删除操作

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it translates to 原子的.

## OzoneManager 元数据布局格式
OzoneManager 支持两种元数据布局格式:简单布局格式和基于前缀的布局格式。

在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键要么是目录名,要么是以父目录唯一标识符为前缀的文件名, 形如 `<parent
Copy link
Contributor

@sky76093016 sky76093016 Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.Extra space
2.要么 is too colloquial.Would it be better to use 可能?

Suggested change
在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键要么是目录名,要么是以父目录唯一标识符为前缀的文件名, 形如 `<parent
在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键可能是目录名,也可能是以父目录唯一标识符为前缀的文件名,形如 `<parent

Copy link
Contributor

@yuangu002 yuangu002 Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iamabug and @sky76093016 for adding zh doc. I think you misunderstood this sentence:

The key to the table is the name of a directory or a file prefixed by the unique identifier of its parent directory, <parent unique-id>/<filename>.

This means that the key is in the format of <parent-id>/<name>, where the name is either a filename or a directory name (depends on DirTable or FileTable). So a correct translation should be something like 主键是以父目录唯一标识符为前缀的文件名或目录名.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yuangu002 I think you are right.

@yuangu002
Copy link
Contributor

Also, @iamabug could you please add zh explanations on the picture? since the picture comes with English.

Copy link
Contributor

@cku328 cku328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iamabug for the translation.
Overall good, I only have some minor comments.

![FSO Rename](PrefixFSO-Rename.png)

## 配置
该特性默认未启用,可以通过在 `ozone-site.xml` 进行如下配置启用:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
该特性默认未启用,可以通过在 `ozone-site.xml` 进行如下配置启用
该特性默认未启用,可以通过在 `ozone-site.xml` 进行如下配置来启用

I think it will read more smoothly.

## OzoneManager 元数据布局格式
OzoneManager 支持两种元数据布局格式:简单布局格式和基于前缀的布局格式。

在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键要么是目录名,要么是以父目录唯一标识符为前缀的文件名, 形如 `<parent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to replace 全路径 with 完整路径?
I think the existing in the original text should be mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cku328 for the suggestion.

  1. I think there is no harm using 完整路径
  2. I am not sure about here. One reason is that the word existing seems to be indicating that this is a design doc before PrefixFSO is implemented. Now that Simple and PrefixFSO both exist, it seems unnecessary to mention Simple as existing.

menu:
main:
parent: 特性
summary: 支持Supports atomic rename and delete operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it translates to 原子的.

@iamabug
Copy link
Contributor Author

iamabug commented Sep 5, 2021

Also, @iamabug could you please add zh explanations on the picture? since the picture comes with English.

Thanks for the suggestion. I agree it would be better to use a picture with Chinese. I think we need the original to do that since we only have .png file here. cc @elek @rakeshadr

@yuangu002
Copy link
Contributor

Also, @iamabug could you please add zh explanations on the picture? since the picture comes with English.

Thanks for the suggestion. I agree it would be better to use a picture with Chinese. I think we need the original to do that since we only have .png file here. cc @elek @rakeshadr

I don't think you need separate pictures. We can use the original pictures, but add an explanation in Chinese which explains what the picture is saying. For example, for the first picture (Legacy layout), you can add a short description (alt text) in Chinese like: 在传统的OM元数据格式中,我们采用完整路径,并且用尾部斜杠来区分目录和键。

@adoroszlai
Copy link
Contributor

Thanks @iamabug @sky76093016 @cku328 @yuangu002 for the patch and reviews. What's the next step here?

smengcl added 2 commits April 28, 2022 11:10
Change-Id: I17519fdcc9caeb76c0170f83e81bdf92af98eb1a
Change-Id: I17940accb0e10d5cd602bbb9fb0bec6a4f13795d
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've amended the usage part of the doc as the original doc is updated.

@adoroszlai
Copy link
Contributor

Thanks @smengcl for updating the translation. It seems the configuration excerpt does not match in the original and translated pages.

smengcl added 2 commits August 2, 2022 12:29
Change-Id: I4fb1b3471b37d93b640c1cdb19f73014bb4f1d7f
Change-Id: I9ec0b75a6df192267ccfee3d2395fe1419db7059
@smengcl
Copy link
Contributor

smengcl commented Aug 2, 2022

Thanks @adoroszlai for pointing that out. Looks like the configuration section has been updated in HDDS-6351. I have pushed updates accordingly.

@adoroszlai adoroszlai merged commit 3b89d4d into apache:master Aug 3, 2022
@adoroszlai
Copy link
Contributor

Thanks @iamabug and @smengcl for the translation, @cku328 and @yuangu002 for the review. Please feel free to open a new PR for further improvements if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants