-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-5564. feature/PrefixFSO.md translation #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @sky76093016 |
| menu: | ||
| main: | ||
| parent: 特性 | ||
| summary: 支持Supports atomic rename and delete operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
支持 and support appear repeatedly, it would be better to change to the above.
| summary: 支持Supports atomic rename and delete operation. | |
| summary: 支持 atomic 重命名和删除操作 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it translates to 原子的.
| ## OzoneManager 元数据布局格式 | ||
| OzoneManager 支持两种元数据布局格式:简单布局格式和基于前缀的布局格式。 | ||
|
|
||
| 在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键要么是目录名,要么是以父目录唯一标识符为前缀的文件名, 形如 `<parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.Extra space
2.要么 is too colloquial.Would it be better to use 可能?
| 在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键要么是目录名,要么是以父目录唯一标识符为前缀的文件名, 形如 `<parent | |
| 在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键可能是目录名,也可能是以父目录唯一标识符为前缀的文件名,形如 `<parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iamabug and @sky76093016 for adding zh doc. I think you misunderstood this sentence:
The key to the table is the name of a directory or a file prefixed by the unique identifier of its parent directory, <parent unique-id>/<filename>.
This means that the key is in the format of <parent-id>/<name>, where the name is either a filename or a directory name (depends on DirTable or FileTable). So a correct translation should be something like 主键是以父目录唯一标识符为前缀的文件名或目录名.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yuangu002 I think you are right.
|
Also, @iamabug could you please add |
cku328
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iamabug for the translation.
Overall good, I only have some minor comments.
|  | ||
|
|
||
| ## 配置 | ||
| 该特性默认未启用,可以通过在 `ozone-site.xml` 进行如下配置启用: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 该特性默认未启用,可以通过在 `ozone-site.xml` 进行如下配置启用: | |
| 该特性默认未启用,可以通过在 `ozone-site.xml` 进行如下配置来启用: |
I think it will read more smoothly.
| ## OzoneManager 元数据布局格式 | ||
| OzoneManager 支持两种元数据布局格式:简单布局格式和基于前缀的布局格式。 | ||
|
|
||
| 在简单布局格式中,OM 采用全路径名来存储每个键的元数据。在基于前缀的优化布局格式中,OM 将中间目录的元数据存储在 `DirectoryTable` 中,将文件的元数据存储在 `FileTable` 中,如下图所示。两张表中的主键要么是目录名,要么是以父目录唯一标识符为前缀的文件名, 形如 `<parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to replace 全路径 with 完整路径?
I think the existing in the original text should be mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cku328 for the suggestion.
- I think there is no harm using
完整路径 - I am not sure about here. One reason is that the word
existingseems to be indicating that this is a design doc before PrefixFSO is implemented. Now that Simple and PrefixFSO both exist, it seems unnecessary to mention Simple as existing.
| menu: | ||
| main: | ||
| parent: 特性 | ||
| summary: 支持Supports atomic rename and delete operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it translates to 原子的.
Thanks for the suggestion. I agree it would be better to use a picture with Chinese. I think we need the original to do that since we only have .png file here. cc @elek @rakeshadr |
I don't think you need separate pictures. We can use the original pictures, but add an explanation in Chinese which explains what the picture is saying. For example, for the first picture (Legacy layout), you can add a short description ( |
|
Thanks @iamabug @sky76093016 @cku328 @yuangu002 for the patch and reviews. What's the next step here? |
Change-Id: I17519fdcc9caeb76c0170f83e81bdf92af98eb1a
Change-Id: I17940accb0e10d5cd602bbb9fb0bec6a4f13795d
smengcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've amended the usage part of the doc as the original doc is updated.
|
Thanks @smengcl for updating the translation. It seems the configuration excerpt does not match in the original and translated pages. |
Change-Id: I4fb1b3471b37d93b640c1cdb19f73014bb4f1d7f
Change-Id: I9ec0b75a6df192267ccfee3d2395fe1419db7059
|
Thanks @adoroszlai for pointing that out. Looks like the configuration section has been updated in HDDS-6351. I have pushed updates accordingly. |
|
Thanks @iamabug and @smengcl for the translation, @cku328 and @yuangu002 for the review. Please feel free to open a new PR for further improvements if needed. |
What changes were proposed in this pull request?
doc translation
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5564
How was this patch tested?
hugo server under docs diectory.