HDDS-5666. Add option to createKey via streaming api in Freon #2574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
changed the title
sadanand48
changed the title
captainzmc
force-pushed
the
HDDS-4454
branch
from
d1e4eea to
89a12ad
Compare
szetszwo
force-pushed
the
HDDS-4454
branch
2 times, most recently
from
f637b1e to
ce1d880
Compare
sadanand48
force-pushed
the
HDDS-5666
branch
from
283c943 to
855d341
Compare
captainzmc
reviewed
Feb 28, 2022
Member
captainzmc
left a comment
captainzmc
left a comment
There was a problem hiding this comment.
Thanks @sadanand48 work on this. I left few comments.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/ContentGenerator.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
This line will conflict with the patch of EC. EC is currently voting on merge to master, so EC will merge into master soon. So can we continue this PR after EC merge?
Contributor
There was a problem hiding this comment.
@sadanand48 , let's hardcode replicationConfig in createStreamKey(..) for the moment. We may change it later if there is a need.
private void createStreamKey(long counter) throws Exception {
final ReplicationConfig replicationConfig = ReplicationConfig
.fromProtoTypeAndFactor(HddsProtos.ReplicationType.RATIS,
HddsProtos.ReplicationFactor.THREE);
final String key = generateObjectName(counter);
timer.time(() -> {
try (OzoneDataStreamOutput stream = bucket
.createStreamKey(key, keySize, replicationConfig, metadata)) {
contentGenerator.write(stream);
}
return null;
});
}
b6f1921 to
f826d12
Compare
Contributor
|
@sadanand48 , there are conflicts. Could could you update the change? |
(cherry picked from commit f623bec992e80eda82e6155a3b20c476e683a3d6)
added 2 commits
April 7, 2022 15:34
szetszwo
approved these changes
Apr 7, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
szetszwo
pushed a commit
to szetszwo/ozone
that referenced
this pull request
May 6, 2022
szetszwo
pushed a commit
that referenced
this pull request
May 13, 2022
szetszwo
pushed a commit
that referenced
this pull request
May 24, 2022
szetszwo
pushed a commit
that referenced
this pull request
Jun 9, 2022
captainzmc
pushed a commit
to captainzmc/hadoop-ozone
that referenced
this pull request
Jul 4, 2022
szetszwo
pushed a commit
that referenced
this pull request
Oct 25, 2022
szetszwo
pushed a commit
that referenced
this pull request
Nov 7, 2022
szetszwo
pushed a commit
that referenced
this pull request
Dec 1, 2022
szetszwo
pushed a commit
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add an option to createKey via streaming api in Freon via OzoneClientKeyGenerator.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5666
How was this patch tested?
Tested the command via docker